Cyril Chemparathy <[email protected]> writes: > Hi Kevin, > > [...] >> Very nice... one minor nit below... > > Thanks. However, I think the solution proposed in [1] is more elegant. > > The way I see it, the root cause of the problem is that some of the > davinci_soc_info fields mapped virtual addresses. Since these virtual > addresses need to be filled in before davinci_common_init(), the current > v4 series implementation contorts the init flow in da8xx and tnetv107x. > > By replacing davinci_soc_info virtual address fields with physical > addresses, we can get by with a single uniform flow that works cleanly > across all three families without said contortions. > > Physical addresses in davinci_soc_info have other pleasant side effects > as well. First, doing so replaces a bunch of IO_ADDRESS() uses in the > mach-davinci code with ioremap(). Second, this also cleans up the early > uses of DA8XX_SYSCFG0_VIRT(). > > Any thoughts on this approach? >
Now *this*, I really, really like. This is an excellent approach. I'll look through the new series later today. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
