Cyril Chemparathy <[email protected]> writes:
> This patch modifies the psc and clock control code to use ioremap()ed
> registers.
>
> Signed-off-by: Cyril Chemparathy <[email protected]>
me really likey
[...]
> @@ -458,8 +457,17 @@ int __init davinci_clk_init(struct clk_lookup *clocks)
> clk->recalc = clk_leafclk_recalc;
> }
>
> - if (clk->pll_data && !clk->pll_data->div_ratio_mask)
> - clk->pll_data->div_ratio_mask = PLLDIV_RATIO_MASK;
> + if (clk->pll_data) {
> + struct pll_data *pll = clk->pll_data;
> +
> + if (!pll->div_ratio_mask)
> + pll->div_ratio_mask = PLLDIV_RATIO_MASK;
> +
> + if (pll->phys_base && !pll->base) {
> + pll->base = ioremap(pll->phys_base, SZ_4K);
> + BUG_ON(!pll->base);
except this. please use WARN_ON() and fail more gracefully
Kevin
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
