Hello, On Fri, May 07, 2010 at 13:54:19, Jon Povey wrote: > My first attempt at a kernel patch.
Welcome! But, this text will make it to git log which isn't interesting to someone who looks at it two years later. In next version this should be replaced with some actual patch description. Any text that should not go into the git log should be placed below the --- > Mostly I am interested in feedback about if my patch posting style is right, I noticed that your description text has more than 80 character lines. That makes for an ugly looking git log and is difficult to read on many e-mail clients. > if this is the right way to deal with this kind of warning, and if this kind > of tiny > patch is welcomed. Sure, warnings are potential bugs. A log of the exact warning would be good. Also the patch will eventually need to be sent to linux-usb mailing list although sending such patches to this list for a pre-review shouldn't be harmful. > > --- > drivers/usb/musb/cppi_dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c > index 59dc3d3..428ca1b 100644 > --- a/drivers/usb/musb/cppi_dma.c > +++ b/drivers/usb/musb/cppi_dma.c > @@ -1155,7 +1155,7 @@ irqreturn_t cppi_interrupt(int irq, void *dev_id) > struct musb_hw_ep *hw_ep = NULL; > u32 rx, tx; > int i, index; > - unsigned long flags; > + unsigned long flags = 0; In case this is not really a bug you can also use uninitialized_var() to suppress the warning. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
