> On Sat, Jul 03, 2010 at 04:08:53, Brian Niebuhr wrote: > > I have included all of the recommended changes in this > version of the patch. > > I also combined the patches into one patch to avoid > bisecting issues. This > > makes the diff on davinci_spi.c very large. > > > > If people who are using this driver could test this version > of the driver > > and Ack it, I would appreciate it. > > > > ** NOTE ** > > > > This patch requires the EDMA patch at: > > > > > http://linux.davincidsp.com/pipermail/davinci-linux-open-sourc > e/2010-March/018022.html > > > > which is queued waiting on another driver fix, for DMA mode > to work correctly. > > > > > > Brian Niebuhr (1): > > davinci: spi: replace existing driver > > > > arch/arm/mach-davinci/board-dm355-evm.c | 10 + > > arch/arm/mach-davinci/board-dm355-leopard.c | 10 + > > arch/arm/mach-davinci/board-dm365-evm.c | 10 + > > arch/arm/mach-davinci/dm355.c | 12 +- > > arch/arm/mach-davinci/dm365.c | 12 +- > > arch/arm/mach-davinci/include/mach/spi.h | 37 +- > > drivers/spi/davinci_spi.c | 1328 > ++++++++++++--------------- > > 7 files changed, 648 insertions(+), 771 deletions(-) > > > > Quick update. > > I tested this patch on DM355 and DM365 EVMs. On DM355 all the > 3 modes (DMA, > Polled and Interrupt) worked fine. But in interrupt mode, on > DM355, if I set > "intr_level = 1", then kernel hangs during booting after printing > "spi spi0.0: DaVinci SPI driver in Interrupt mode" on the console.
Sudhakar - When you changed the interrupt level, did you also change the IORESOURCE_IRQ entry for SPI0? Maybe we could set the interrupt level automatically based on the IORESOURCE_IRQ provided? The problem is, I don't see any way of doing that without a bunch of machine-specific ifdefs in the driver. > On DM365 only DMA and Polled mode worked fine. In interrupt > mode, whether I > set intr_level to ZERO or ONE, kernel booting hangs, similar to DM355. Does the interrupt mode of the existing driver work on DM365? I don't have one of these boards, so I can't debug the issue. If you have any ideas where the problem might be I'd appreciate the help in getting this resolved. If the change I mentioned above fixes the issue on DM355, then I've got to imagine that it's just a configuration issue of some sort on DM365. > I'll update the status of testing on OMAP-L1x EVMs later. > > I am using the Linux kernel from [1] for testing. > > [1] > http://git.kernel.org/?p=linux/kernel/git/khilman/linux-davinc > i.git;a=summary _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
