Hello Raffaele,

When you submit an Nth version of a patch, can you please put
a vN after PATH in the subject? That way it is easier for maintainer
to find out the latest version of the patch.

On Wed, Jul 14, 2010 at 19:51:09, Raffaele Recalcati wrote:
> From: Davide Bonfanti <[email protected]>
>
>     Clockout2 is added as a child of pll1_sysclk9, because they have
>     the same pll divisor.
>     Added dm365_clkout2_set_rate to properly set clockout2 frequency.
>     Modified the davinci_set_sysclk_rate function in order
>     to get the right ancestor.
>
>     This patch has been developed against the
>     http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git
>     git tree and tested on bmx board.
>
> Signed-off-by: Davide Bonfanti <[email protected]>
> Signed-off-by: Raffaele Recalcati <[email protected]>

[...]

> +static struct clk clkout2_clk = {
> +     .name           = "clkout2",
> +     .parent         = &pll1_sysclk9,
> +     .flags          = CLK_PLL,
> +     .div_reg        = PLLDIV9,

div_reg is for sysclks only. Since this is a child
of sysclk and not sysclk itself, setting this here
would be incorrect.

> +     .set_rate       = davinci_set_sysclk_rate,

Shouldn't you be using the newly introduced dm365_clkout2_set_rate
here?

Thanks,
Sekhar

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to