Re: [PATCH 1/8] netdev: separate out davinci mdio controller code

Tue, 03 Aug 2010 17:44:52 -0700 

Hi Omar,

[...]
>> +    while ((reg = __raw_readl(&regs->user[0].access)) & USERACCESS_GO)
>> +            ;
> 
> potential infinite loop? I saw another place in your series using time_after, 
> might fit in here too.
[...]
>> +    while ((__raw_readl(&regs->control) & CONTROL_IDLE) == 0)
>> +            ;
> 
> Ditto

Thanks.  Will modify.

Regards
Cyril.
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to