"Nori, Sekhar" <[email protected]> writes: > On Thu, Aug 05, 2010 at 23:50:13, Kevin Hilman wrote: >> Sekhar Nori <[email protected]> writes: >> >> > This patch adds support to configure the AEMIF interface >> > with supplied timing values. >> > >> > Since this capability is useful both from NOR and NAND >> > flashes, it is provided as a new interface and in a file >> > of its own. >> > >> > AEMIF timing configuration is required in cases: >> > >> > 1) Where the AEMIF clock rate can change at runtime (a side >> > affect of cpu frequency change). >> > >> > 2) Where U-Boot does not support NAND/NOR but supports other >> > media like SPI Flash or MMC/SD and thus does not care about >> > setting up the AEMIF timing for kernel to use. >> > >> > 3) Where U-Boot just hasn't configured the timing values and >> > cannot be upgraded because the box is already in the field. >> > >> > Since there is now a header file for AEMIF interface, the >> > common (non-NAND specific) defines for AEMIF registers have >> > been moved from nand.h into the newly created aemif.h >> > >> > Signed-off-by: Sekhar Nori <[email protected]> >> >> This series looks great, and is a very nice cleanup. Also, those >> performance improvments are pretty impressive. >> >> Apart from the minor comment below (which I can fixup myself if you >> approve), I'll apply this whole series. > > Thanks Kevin! > > Patch 2/6 touches mtd nand driver. Do you want to take that patch through > davinci as well? I guess mtd list would have to be involved someway. Shall > I post the series to mtd list with your sign-off/ack to see what the mtd > maintainer wants to do?
Yes please. You can add my ack. >> >> [...] >> >> > + >> > +#define TIMING_MASK (TA(TA_MAX) | \ >> > + RHOLD(RHOLD_MAX) | \ >> > + RSTROBE(RSTROBE_MAX) | \ >> > + RSETUP(RSETUP_MAX) | \ >> > + WHOLD(WHOLD_MAX) | \ >> > + WSTROBE(WSTROBE_MAX) | \ >> > + WSETUP(WSETUP_MAX)) >> > + >> > +#define NS_IN_KHZ 1000000 >> >> Minor nit: <linux/time.h> already nas NSEC_PER_MSEC, can use that instead. > > If I am going to have to re-post this, I can make this change while > posting. OK, thanks. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
