On Tue, Aug 31, 2010 at 9:51 AM, Syed Mohammed, Khasim <[email protected]> wrote:
>
>
>> -----Original Message-----
>> From: [email protected] [mailto:davinci-
>> [email protected]] On Behalf Of Victor Rodriguez
>> Sent: Tuesday, August 31, 2010 8:16 PM
>> To: Sergei Shtylyov; [email protected]
>> Subject: Re: [PATCH] hawkboard
>>
>> On Tue, Aug 31, 2010 at 4:07 AM, Sergei Shtylyov <[email protected]>
>> wrote:
>> > Victor Rodriguez wrote:
>> >>
>> >> Basic support for Hawkboard OMAPL138 just UART cominication is included
>> >
>> >> Signed-off-by: Victor Rodriguez <[email protected]>
>> >
>> >> Notes: This patch is checked with 0a50e05b20f3c6af67656303bdb3661a2541ce03
>> >> from
>> >> Kernel development tree for TI DaVinci family of processors
>> >
>> >> This patch works with basic da8xx_omapl_defconfig, it just have
>> >> basic support
>> >> for UART console
>> >> ---
>> >> arch/arm/mach-davinci/Kconfig | 9 +++
>> >> arch/arm/mach-davinci/Makefile | 1 +
>> >> arch/arm/mach-davinci/board-da850-hawk.c | 69
>> >> +++++++++++++++++++++++
>> >> arch/arm/mach-davinci/include/mach/uncompress.h | 1 +
>> >> 4 files changed, 80 insertions(+), 0 deletions(-)
>> >> create mode 100644 arch/arm/mach-davinci/board-da850-hawk.c
>> >>
>> >> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
>> >> index 2bf03e9..fd8a11c 100644
>> >> --- a/arch/arm/mach-davinci/Kconfig
>> >> +++ b/arch/arm/mach-davinci/Kconfig
>> >> @@ -185,6 +185,15 @@ config MACH_TNETV107X
>> >> help
>> >> Say Y here to select the TI TNETV107X Evaluation Module.
>> >>
>> >> +config MACH_OMAPL138_HAWKBOARD
>> >> + bool "TI DA850/OMAP-L138/AM18xx Hawkboard(.org) Platform"
>> >> + default ARCH_DAVINCI_DA850
>> >
>> > Only EVM boards are enabled by default.
>> >
>> >> + depends on ARCH_DAVINCI_DA850
>> >> + help
>> >> + Say Y here to select the TI DA850/OMAP-L138/AM18xx Hawkboard.
>> >> + Information of this board may be found at
>> >> + http://www.hawkboard.org/
>> >> +
>> >> config DAVINCI_MUX
>> >> bool "DAVINCI multiplexing support"
>> >> depends on ARCH_DAVINCI
>> >
>> > [...]
>> >>
>> >> diff --git a/arch/arm/mach-davinci/board-da850-hawk.c
>> >> b/arch/arm/mach-davinci/board-da850-hawk.c
>> >> new file mode 100644
>> >> index 0000000..e34bcbb
>> >> --- /dev/null
>> >> +++ b/arch/arm/mach-davinci/board-da850-hawk.c
>> >> @@ -0,0 +1,69 @@
>> >> +/*
>> >> + * Hawkboar.org based on TI's OMAP-L138 Platform
>> >
>> > Hawkboard.org?
>> >
>> >> + *
>> >> + * Initial code: Syed Mohammed Khasim
>> >> + *
>> >> + * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com
>> >> + *
>> >> + * Derived from: arch/arm/mach-davinci/board-da850-evm.c
>> >> + * Original Copyrights follow:
>> >> + *
>> >> + * 2007, 2009 (c) MontaVista Software, Inc. This file is licensed under
>> >
>> > MV didn't write any code in board-da850-evm.c, so the original copyright
>> > is wrong.
>>
>>
>> One question i was looking for the root of the original code and found this
>>
>> board-da850-hawk.c is derived from
>>
>>
>> arch/arm/mach-davinci/board-da850-evm.c
>>
>> and it is derived from
>>
>> arch/arm/mach-davinci/board-da830-evm.c
>>
>> and it is derived from
>>
>> arch/arm/mach-davinci/board-dm644x-evm.c
>>
>> which shows this
>>
>> /*
>> * TI DaVinci EVM board support
>> *
>> * Author: Kevin Hilman, MontaVista Software, Inc. <[email protected]>
>> *
>> * 2007 (c) MontaVista Software, Inc. This file is licensed under
>> * the terms of the GNU General Public License version 2. This program
>> * is licensed "as is" without any warranty of any kind, whether express
>> * or implied.
>> */
>>
>> Until i understand Kevin wrote that code there is no more derived from
>> so i think the best is to keep with that copy right but, is just a
>> question please tell me which should i write like original copy right
>>
>>
> I generally follow the immediate one, in this case we can say derived from
> board-da850-evm.c, with this we will know which code to refer for in future
> for porting or merging. We can track any changes that happen to this board
> file and are generic to be taken up across the da850 based boards.
Thanks Khasim I will keep it just like you wrote in the original
board-da850-hawk.c
Bye the way Nori and Caglar found these mistake about serial
change the console= kernel parameter to ttyS0?
Any clue I really do not understand.
Until I understand the serial port works fine for my Hawkboard if i keep
__raw_writel(0, IO_ADDRESS(DA8XX_UART1_BASE) + 0x30);
__raw_writel(0, IO_ADDRESS(DA8XX_UART0_BASE) + 0x30);
Otherwise it will show the
too much work in irq53
too much work in irq53
...
messages
Thanks for the help and do not worry about the work to get this patch
accepted I like these job
Best regards
Victor Rodriguez
>
>>
>> >> + * the terms of the GNU General Public License version 2. This program
>> >> + * is licensed "as is" without any warranty of any kind, whether express
>> >> + * or implied.
>> >> + */
>> >> +#include <linux/kernel.h>
>> >> +#include <linux/init.h>
>> >> +#include <linux/console.h>
>> >> +#include <linux/gpio.h>
>> >> +
>> >> +#include <asm/mach-types.h>
>> >> +#include <asm/mach/arch.h>
>> >> +
>> >> +#include <mach/cp_intc.h>
>> >> +#include <mach/da8xx.h>
>> >> +
>> >> +
>> >> +
>> >
>> > Too many empty lines?
>> >
>> >> +static struct davinci_uart_config omapl138_hawk_uart_config __initdata =
>> >> {
>> >> + .enabled_uarts = 0x7,
>> >
>> > Why enable URARTs 0 and 1 if you shut down them below?
>> >
>> >> +};
>> >> +
>> >> +static __init void omapl138_hawk_init(void)
>> >> +{
>> >> +
>> >> + davinci_serial_init(&omapl138_hawk_uart_config);
>> >> +
>> >> + /*
>> >> + * shut down uart 0 and 1; they are not used on the board and
>> >> + * accessing them causes endless "too much work in irq53" messages
>> >> + * with arago fs
>> >> + */
>> >> + __raw_writel(0, IO_ADDRESS(DA8XX_UART1_BASE) + 0x30);
>> >> + __raw_writel(0, IO_ADDRESS(DA8XX_UART0_BASE) + 0x30);
>> >> +
>> >> +}
>> >
>> > WBR, Sergei
>> >
>> >
>>
>> Whit Best Regards
>>
>> Victor Rodriguez
>> _______________________________________________
>> Davinci-linux-open-source mailing list
>> [email protected]
>> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
>
> Regards,
> Khasim
>
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
