On Wed, Sep 8, 2010 at 7:17 AM, Nori, Sekhar <[email protected]> wrote:
> Hi Victor,
>
> On Wed, Sep 08, 2010 at 01:32:04, Victor Rodriguez wrote:
>> This patch adds initial support for the Hawkboard-L138 system
>> It is under the machine name "omapl138_hawkboard".
>> This system is based on the da850 davinci CPU architecture.
>> Information on these system may be found at http://www.hawkboard.org.
>> Basic support for the UART console is included in this patch.
>> Depends on Michael Williamson patches:
>> http://alturl.com/hha7u and http://alturl.com/qy4cr
>
> Patch dependencies should be noted below the ---
>
>>
>> Signed-off-by: Victor Rodriguez <[email protected]>
>> ---
>> Changes since v4:
>> 1) Registering UART 0 and UART 2, UART 1 is not available on hardware
>> 2) Add Watch dog timer function
>>
>> Notes:
>>
>> This patch is checked with 0a50e05b20f3c6af67656303bdb3661a2541ce03
>> from Kernel development tree for TI DaVinci family of processors.
>> This patch works with da8xx_omapl_defconfig plus this patch.
>> Depens on patches http://alturl.com/hha7u and http://alturl.com/qy4cr
>>
>> arch/arm/configs/da8xx_omapl_defconfig | 1 +
>> arch/arm/mach-davinci/Kconfig | 8 +++
>> arch/arm/mach-davinci/Makefile | 1 +
>> arch/arm/mach-davinci/board-da850-hawk.c | 66
>> +++++++++++++++++++++++
>> arch/arm/mach-davinci/include/mach/uncompress.h | 1 +
>> 5 files changed, 77 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/mach-davinci/board-da850-hawk.c
>>
>> diff --git a/arch/arm/configs/da8xx_omapl_defconfig
>> b/arch/arm/configs/da8xx_omapl_defconfig
>> index 3952a4e..d7cb4b8 100644
>> --- a/arch/arm/configs/da8xx_omapl_defconfig
>> +++ b/arch/arm/configs/da8xx_omapl_defconfig
>> @@ -17,6 +17,7 @@ CONFIG_MODVERSIONS=y
>> CONFIG_ARCH_DAVINCI=y
>> CONFIG_ARCH_DAVINCI_DA830=y
>> CONFIG_ARCH_DAVINCI_DA850=y
>> +CONFIG_MACH_OMAPL138_HAWKBOARD=y
>> CONFIG_DAVINCI_RESET_CLOCKS=y
>> CONFIG_NO_HZ=y
>> CONFIG_HIGH_RES_TIMERS=y
>> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
>> index 2bf03e9..985c261 100644
>> --- a/arch/arm/mach-davinci/Kconfig
>> +++ b/arch/arm/mach-davinci/Kconfig
>> @@ -185,6 +185,14 @@ config MACH_TNETV107X
>> help
>> Say Y here to select the TI TNETV107X Evaluation Module.
>>
>> +config MACH_OMAPL138_HAWKBOARD
>> + bool "TI AM1808 / OMAPL138 Hawkboard platform"
>
> s/OMAPL138/OMAP-L138
>
>> + depends on ARCH_DAVINCI_DA850
>> + help
>> + Say Y here to select the TI AM1808 / OMAPL138 Hawkboard platform .
>
> s/OMAPL138/OMAP-L138
>
>> + Information of this board may be found at
>> + http://www.hawkboard.org/
>> +
>> config DAVINCI_MUX
>> bool "DAVINCI multiplexing support"
>> depends on ARCH_DAVINCI
>> diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile
>> index 77a0f71..484071d 100644
>> --- a/arch/arm/mach-davinci/Makefile
>> +++ b/arch/arm/mach-davinci/Makefile
>> @@ -33,6 +33,7 @@ obj-$(CONFIG_MACH_DAVINCI_DM365_EVM) +=
>> board-dm365-evm.o
>> obj-$(CONFIG_MACH_DAVINCI_DA830_EVM) += board-da830-evm.o
>> obj-$(CONFIG_MACH_DAVINCI_DA850_EVM) += board-da850-evm.o
>> obj-$(CONFIG_MACH_TNETV107X) += board-tnetv107x-evm.o
>> +obj-$(CONFIG_MACH_OMAPL138_HAWKBOARD) += board-da850-hawk.o
>>
>> # Power Management
>> obj-$(CONFIG_CPU_FREQ) += cpufreq.o
>> diff --git a/arch/arm/mach-davinci/board-da850-hawk.c
>> b/arch/arm/mach-davinci/board-da850-hawk.c
>> new file mode 100644
>> index 0000000..b71a6a7
>> --- /dev/null
>> +++ b/arch/arm/mach-davinci/board-da850-hawk.c
>> @@ -0,0 +1,66 @@
>> +/*
>> + * Hawkboard.org based on TI's OMAP-L138 Platform
>> + *
>> + * Initial code: Syed Mohammed Khasim
>> + *
>> + * Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com
>> + *
>> + * This file is licensed under the terms of the GNU General Public License
>> + * version 2. This program is licensed "as is" without any warranty of
>> + * any kind, whether express or implied.
>> + */
>> +#include <linux/kernel.h>
>> +#include <linux/init.h>
>> +#include <linux/console.h>
>> +#include <linux/gpio.h>
>> +
>> +#include <asm/mach-types.h>
>> +#include <asm/mach/arch.h>
>> +
>> +#include <mach/cp_intc.h>
>> +#include <mach/da8xx.h>
>> +
>> +static struct davinci_uart_config omapl138_hawk_uart_config __initdata = {
>> + .enabled_uarts = 0x7,
>> +};
>> +
>> +static __init void omapl138_hawk_init(void)
>> +{
>> + int ret;
>> +
>> + davinci_serial_init(&omapl138_hawk_uart_config);
>> +
>> + /*shut down uart 1; It is not implemented in hardware */
>
> Should be: /* Shut down ...
>
> I thought there was going to be a note here as to
> why we register UART1, but choose to shut it down?
The UART1 is not present in the board, we are registering first the
UART0,1 and 2 and then just shut down UART1 because it is not present
in hardware. But what do you suggest.
Thanks
VIctor Rodriguez
>> + __raw_writel(0, IO_ADDRESS(DA8XX_UART1_BASE) + 0x30);
>> +
>> + ret = da8xx_register_watchdog();
>> + if (ret)
>> + pr_warning("evm_init: watchdog registration failed: %d\n",
>
> It is not evm board..
>
>> + ret);
>> +}
>> +
>> +#ifdef CONFIG_SERIAL_8250_CONSOLE
>> +static int __init omapl138_hawk_console_init(void)
>> +{
>> + if (!machine_is_omapl138_hawkboard())
>> + return 0;
>> +
>> + return add_preferred_console("ttyS", 2, "115200");
>> +}
>> +console_initcall(omapl138_hawk_console_init);
>> +#endif
>> +
>> +static void __init omapl138_hawk_map_io(void)
>> +{
>> + da850_init();
>> +}
>> +
>> +MACHINE_START(OMAPL138_HAWKBOARD, "OMAP-L138")
>
> OMAP-L138 is just the processor name. What is expected here is
> the board name. It should be "AM18x/OMAP-L138 Hawkboard"
>
> Thanks,
> Sekhar
>
>
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source