On Mon, Oct 11, 2010 at 10:43 AM, Kevin Hilman <[email protected]> wrote: > <[email protected]> writes: > >> From: Victor Rodriguez <[email protected]> >> >> This patch adds >> EMAC, EDMA, ASoC, SOUND, MMC/SD and USB OHCI >> support for the Hawkboard-L138 system > >> It is under the machine name "omapl138_hawkboard". >> This system is based on the da850 davinci CPU architecture. > > Please remove these 2 sentences from all the changelogs. > > In addition to Sergei's comments, which I completely agree with, I have > some general comments: > > When you cut and paste from other board files, please also update the > comments. I see at least a couple places where comments in this code > refers to the EVM. > > Also, since I don't have a hawkboard, before merging, it would be nice > to see some more folks that have these boards test the various features > in this series and reply with their 'Tested-by' > > Kevin
Hi I have changed all the Segei's comments and besides the EVM comments thanks a lot for your observations. I have sanded the v2 patches with corrections Caglar i would like to ask you to check the patches. I know you have much more experience that me and you could make better observations. Thanks a lot Sincerely yours Victor Rodriguez >> Victor Rodriguez (6): >> davinci: EMAC support for Omapl138-Hawkboard >> davinci: EDMA support for Omapl138-Hawkboard >> ASoC: davinci: ASoC support for Omapl138-Hawkboard >> davinci: SOUND support for Omapl138-Hawkboard >> davinci: MMC/SD support for Omapl138-Hawkboard >> davinci: USB-OHCI support for Omapl138-Hawkboard >> >> arch/arm/mach-davinci/board-omapl138-hawk.c | 294 >> +++++++++++++++++++++++++++ >> arch/arm/mach-davinci/da850.c | 21 ++- >> arch/arm/mach-davinci/include/mach/mux.h | 2 + >> sound/soc/davinci/Kconfig | 5 +- >> sound/soc/davinci/davinci-evm.c | 6 +- >> 5 files changed, 323 insertions(+), 5 deletions(-) >> >> _______________________________________________ >> Davinci-linux-open-source mailing list >> [email protected] >> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
