On Thu, Oct 28, 2010 at 19:34:10, Nori, Sekhar wrote:
> Hi Victor,
>
> Sorry for jumping late on this. Some comments below:
>
> On Tue, Oct 19, 2010 at 23:36:19, vm.ro...@gmail.com wrote:
> > From: Victor Rodriguez <victor.rodrig...@sasken.com>
> >
> > This patch adds EMAC support for the Hawkboard-L138 system
> >
> > Signed-off-by: Victor Rodriguez <victor.rodrig...@sasken.com>
> > ---
> > arch/arm/mach-davinci/board-omapl138-hawk.c | 47
> > +++++++++++++++++++++++++++
> > 1 files changed, 47 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c
> > b/arch/arm/mach-davinci/board-omapl138-hawk.c
> > index c472dd8..8633245 100644
> > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
> > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
> > @@ -19,6 +19,51 @@
> >
> > #include <mach/cp_intc.h>
> > #include <mach/da8xx.h>
> > +#include <mach/mux.h>
> > +
> > +#define HAWKBOARD_PHY_ID "0:07"
> > +
> > +static short omapl138_hawk_mii_pins[] __initdata = {
> > + DA850_MII_TXEN, DA850_MII_TXCLK, DA850_MII_COL, DA850_MII_TXD_3,
> > + DA850_MII_TXD_2, DA850_MII_TXD_1, DA850_MII_TXD_0, DA850_MII_RXER,
> > + DA850_MII_CRS, DA850_MII_RXCLK, DA850_MII_RXDV, DA850_MII_RXD_3,
> > + DA850_MII_RXD_2, DA850_MII_RXD_1, DA850_MII_RXD_0, DA850_MDIO_CLK,
> > + DA850_MDIO_D,
> > + -1
>
> -1 need not be a new line. In any case, please include a ',' after it.
The justification for a ',' in the end is that it makes it easier
to add new initialization elements. Since -1 is going to be
the last one anyway, please ignore this comment.
Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
