Hi Sekhar, On Tue, Nov 16, 2010 at 10:18 AM, Nori, Sekhar <[email protected]> wrote: > [...] > I am not sure if such platform specific changes are encouraged > in a generic file like drivers/gpio/Kconfig. I don't know a better > way to achieve this either :(
I agree: it is wrong to put platform specific changes into the generic areas... > This change will need to get reviewed by a wider list. Yes, I was afraid of that. :) Perhaps it can be kept local instead -- more below. >> * adding David Brownell because I think he is the pca953x goto guy > > scripts/get_maintainer.pl -f drivers/gpio/Kconfig > > gives: > > Andrew Morton <[email protected]> > Samuel Ortiz <[email protected]> > Mark Brown <[email protected]> > Rabin Vincent <[email protected]> > Linus Walleij <[email protected]> > [email protected] > > Can you please re-send this patch with these folks and lists in CC too? I had an even longer list generated with the --rolestats output on the patch, the pca593x.c file, the kconfig etc. I got gunshy right about posting time due to what I've read recently about the resentment of long CC lists [1] Producing this version of the patch made me think "it would be nice if I could just say select y OR m" or something like that... It turns out that Stephen Rothwell had already thought about this [2]. In that thread Sam Ravnborg pointed out [3] that assignments of attributes to config entries can be done in separate files. So I can add config GPIO_PCA953X default y if MACH_DAVINCI_DA850_EVM to the arch/arm/mach-davinci/Kconfig file. Problem solved; no need to involve a whole bunch of people who have more important things to do than look at this little patch of mine. Mr. David Brownell, I'm sorry for the noise. I wish I had thought of this method sooner. Best Regards, Ben Gardiner [1] http://lwn.net/Articles/404105/ [2] http://article.gmane.org/gmane.linux.ports.ppc.embedded/36839 [3] http://article.gmane.org/gmane.linux.ports.ppc.embedded/37132 --- Nanometrics Inc. http://www.nanometrics.ca _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
