Hello Victor, On 11/19/2010 11:22 AM, [email protected] wrote:
> From: Victor Rodriguez <[email protected]> > > Generic pin list has RTS and CTS pins defined > for UART1 and UART2. > > Signed-off-by: Victor Rodriguez <[email protected]> > --- I don't think this patch is complete, it will break the current boards with out some other modifications first. (see below) > arch/arm/mach-davinci/da850.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c > index b3b1adb..d36e767 100644 > --- a/arch/arm/mach-davinci/da850.c > +++ b/arch/arm/mach-davinci/da850.c > @@ -420,9 +420,13 @@ static const struct mux_config da850_pins[] = { > MUX_CFG(DA850, UART0_RXD, 3, 16, 15, 2, false) > MUX_CFG(DA850, UART0_TXD, 3, 20, 15, 2, false) > /* UART1 function */ > + MUX_CFG(DA850, NUART1_CTS, 0, 20, 15, 2, false) > + MUX_CFG(DA850, NUART1_RTS, 0, 16, 15, 2, false) > MUX_CFG(DA850, UART1_RXD, 4, 24, 15, 2, false) > MUX_CFG(DA850, UART1_TXD, 4, 28, 15, 2, false) > /* UART2 function */ > + MUX_CFG(DA850, NUART2_CTS, 0, 28, 15, 2, false) > + MUX_CFG(DA850, NUART2_RTS, 0, 24, 15, 2, false) > MUX_CFG(DA850, UART2_RXD, 4, 16, 15, 2, false) > MUX_CFG(DA850, UART2_TXD, 4, 20, 15, 2, false) > /* I2C1 function */ > @@ -578,12 +582,12 @@ const short da850_uart0_pins[] __initdata = { > }; > > const short da850_uart1_pins[] __initdata = { > - DA850_UART1_RXD, DA850_UART1_TXD, > + DA850_NUART1_CTS, DA850_NUART1_RTS, DA850_UART1_RXD, DA850_UART1_TXD, > -1 > }; > > const short da850_uart2_pins[] __initdata = { > - DA850_UART2_RXD, DA850_UART2_TXD, > + DA850_NUART2_CTS, DA850_NUART2_RTS, DA850_UART2_RXD, DA850_UART2_TXD, > -1 > }; > I think all the da850_uart?_pins[] should be deleted from this file. Instead, each of the board files should have a local/static __initdata definition for these pins (without the RTS/CTS for the uart1 and uart2 for current boards). You'll have to hit each of the da850 board files. Same approach would apply for the mcasp pins (delete from da850.c, add to board files supporting mcasp configuration). I think the others (ethernet pins, emif25 pins) could simply be deleted (nothing is referencing them). You could probably cover all those in a common patch series under the title of "clean up generic pin lists for da850"... Thanks for taking a crack at it. I was going to volunteer seeing as I made the stink about it but you beat me to the punch. -Mike _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
