Hello.
On 29-11-2010 16:22, Subhasish Ghosh wrote:
The patch adds support for the programmable realtime unit (PRU)
available on OMAPL138. This defines the system resource
requirements such as pin mux, clock, iomem, interrupt etc
and registers the platform device as per the Linux driver model.
Signed-off-by: Subhasish Ghosh<[email protected]>
[...]
diff --git a/arch/arm/mach-davinci/da850.c
b/arch/arm/mach-davinci/da850.c
index 63916b9..59a3638 100644
--- a/arch/arm/mach-davinci/da850.c
+++ b/arch/arm/mach-davinci/da850.c
@@ -238,6 +238,13 @@ static struct clk tptc2_clk = {
.flags = ALWAYS_ENABLED,
};
+static struct clk pru_clk = {
+ .name = "pru_ck",
+ .parent =&pll0_sysclk2,
+ .lpsc = DA8XX_LPSC0_DMAX,
+ .flags = ALWAYS_ENABLED,
Why it's always enabled?
[SG] - As per the L138 Datasheet, this falls under "Always On" domain.
Well, this has been discussed already...
BTW, you have a very strange mailer. It shouldn't present your replies as
quotes...
@@ -390,12 +398,15 @@ static struct clk_lookup da850_clks[] = {
CLK(NULL, NULL, NULL),
};
-/*
- * Device specific mux setup
- *
- * soc description mux mode mode mux dbg
- * reg offset mask mode
+/* soc -> DA850
+ * desc -> Pin name, which evaluates to soc##_##desc.
+ * muxreg -> Pin Multiplexing Control n (PINMUXn) Register
number.
+ * mode_offset -> Bit offset in the register PINMUXn.
+ * mode_mask -> Number of bits for Pin Multiplexing Control n.
+ * mux_mode -> Multiplexing mode to set.
+ * dbg -> debug on/off.
Why are you changing this at all?
You didn't reply.
+ MUX_CFG(DA850, PRU0_R31_0, 7, 28, 15, 0, false)
+ MUX_CFG(DA850, PRU1_R30_15, 12, 0, 15, 4, false)
+ MUX_CFG(DA850, PRU1_R31_18, 11, 20, 15, 0, false)
Please align with the other initializers. And are these all PRU pins?
[SG] - Yes, all of these are PRU pins.
I meant to ask if these are all PRU pins in existence?
diff --git a/arch/arm/mach-davinci/devices-da8xx.c
b/arch/arm/mach-davinci/devices-da8xx.c
index 9eec630..11a9b67 100644
--- a/arch/arm/mach-davinci/devices-da8xx.c
+++ b/arch/arm/mach-davinci/devices-da8xx.c
@@ -85,6 +86,42 @@ struct platform_device da8xx_serial_device = {
[...]
+static struct platform_device omapl138_pru_can_device = {
+ .name = "davinci_pru_can",
+ .id = 1,
Why 1? Is there other device? I don't see them...
You didn't reply.
diff --git a/include/linux/can/platform/ti_omapl_pru_can.h
b/include/linux/can/platform/ti_omapl_pru_can.h
new file mode 100644
index 0000000..0dea436
--- /dev/null
+++ b/include/linux/can/platform/ti_omapl_pru_can.h
@@ -0,0 +1,29 @@
I think this file belongs to the driver patch...
[SG] -- This header file is included in devices-da8xx.c.
I understand. Nevertheless, the file path suggests that this should be a
part of the driver patch rather than platform patch. You simply needed to post
the driver patch before the platfrom patch.
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
