On Tuesday 30 November 2010 11:36:01 am Nori, Sekhar wrote: > Hi Caglar, > > On Thu, Sep 02, 2010 at 02:11:17, Caglar Akyuz wrote: > > [...] > > > I think race is between irq_handler and fb_setcolreg. Registering > > irq_handler at the end of probe function solves the issue.(Patch is > > attached) I don't know da8xx lcd controller enough but one of your > > comments in the code says lcd raster controller should be disabled prior > > to any register update. So I think following sequence happens on my > > board: > > > > - raster controller is disabled > > - fb_setcolreg is called at boot time as you pointed out > > - irq fires-up, enables raster controller > > - fb_setcolreg calls lcd_blit which modifies LCD_RASTER_CTRL_REG while > > raster controller is enabled > > > > printk delayed irq and the problem disappeared, registering irq at the > > end of probe function served the same purpose. > > Do you plan to submit this patch upstream? Registering IRQ towards > the end of probe sounds like something which is useful in general > and (IMHO) should be easy to get upstream acceptance. > > Thanks, > Sekhar >
I'll submit the patch in a few minutes. Regards, Caglar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
