Hi Cyril, On Tue, Dec 07, 2010 at 20:22:01, Chemparathy, Cyril wrote: > The tnetv107x evm board has a backlight device that is connected on one of the > SSP ports. This patch adds the board definitions necessary to plug the > backlight driver to the GPIO corresponding to this SSP pin. > > Signed-off-by: Cyril Chemparathy <[email protected]> > --- > arch/arm/mach-davinci/board-tnetv107x-evm.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c > b/arch/arm/mach-davinci/board-tnetv107x-evm.c > index e3863dd..ac62de2 100644 > --- a/arch/arm/mach-davinci/board-tnetv107x-evm.c > +++ b/arch/arm/mach-davinci/board-tnetv107x-evm.c > @@ -44,6 +44,7 @@ > #define EVM_MMC_WP_GPIO 21 > #define EVM_MMC_CD_GPIO 24 > #define EVM_SPI_CS_GPIO 54 > +#define EVM_BACKLIGHT_GPIO (SSP_GPIO_START + 2) > > static int initialize_gpio(int gpio, char *desc) > { > @@ -353,6 +354,12 @@ static struct spi_board_info spi_info[] __initconst = { > }, > }; > > +static struct platform_device backlight_device = { > + .name = "tps6116x", > + .id = -1, > + .dev.platform_data = (void *)EVM_BACKLIGHT_GPIO, > +}; > + > static __init void tnetv107x_evm_board_init(void) > { > davinci_cfg_reg_list(sdio1_pins); > @@ -364,6 +371,13 @@ static __init void tnetv107x_evm_board_init(void) > spi_register_board_info(spi_info, ARRAY_SIZE(spi_info)); > } > > +static int __init tnetv107x_evm_late_init(void) > +{ > + platform_device_register(&backlight_device); > + return 0; > +} > +late_initcall(tnetv107x_evm_late_init);
This call should simply return if machine is not tnetv107x EVM. I didn't follow the entire series but wondering why platform device registration should be a late init call. Typically the driver probe can be made a late init call in case of init sequence dependencies. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
