On Mon, Dec 13, 2010 at 4:53 PM, Kevin Hilman <[email protected]> wrote: > Ben Gardiner <[email protected]> writes: >> [...] >> Everything seems to be in order there; I tested the resulting kernel >> with evtest and the expected output was observed. Note that >> davinci-next still contains the cherry-pick of the upstream commit of >> the polled gpio keys driver: > > oops... I've now removed that, since it is part of v2.6.36-rc5 already. > Thanks for checking.
Oops on my part... I looked at git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git#davinci-next again ; HEAD at the time was: commit 5682cfebad5e68736f4c54a268b5b371698f5262 Author: Ben Gardiner <[email protected]> Date: Thu Dec 9 16:51:07 2010 -0500 da850-evm: KEYBOARD_GPIO_POLLED Kconfig conditional Use the mach-davinci/Kconfig to enable gpio-keys-polled as default when da850-evm machine is enabled. Signed-off-by: Ben Gardiner <[email protected]> CC: Kevin Hilman <[email protected]> CC: "Nori, Sekhar" <[email protected]> CC: Gabor Juhos <[email protected]> Signed-off-by: Kevin Hilman <[email protected]> and I was unable to build a kernel from da8xx_omapl_defconfig b/c: arch/arm/mach-davinci/board-da850-evm.c:333: error: unknown field 'poll_interval' specified in initializer It appears that dropping the cherry-pick caused the build failure. The commit that introduces the polled gpio keys driver (which was included in the series as a cherry pick) is commit 0e7d0c860a0dee49dacb7bbb248d1eba637075ad which is in git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git#master _after_ the tag v2.6.37-rc5. That's my fault. I incorrectly thought that commit 0e7d0c860a0dee49dacb7bbb248d1eba637075ad was _in_ 2.6.37-rc5 and stated this is previous emails. I'm sorry for the confusion; I think I jumped the gun there due to my excitement at getting this prerequisite driver committed. Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
