Hello. On 07-01-2011 16:40, Manjunath Hadli wrote:
This patch implements the overall device creation for the Video display driver.
Signed-off-by: Manjunath Hadli<[email protected]> Acked-by: Muralidharan Karicheri<[email protected]> Acked-by: Hans Verkuil<[email protected]>
[...]
diff --git a/arch/arm/mach-davinci/include/mach/dm644x.h b/arch/arm/mach-davinci/include/mach/dm644x.h index 5a1b26d..b59591c 100644 --- a/arch/arm/mach-davinci/include/mach/dm644x.h +++ b/arch/arm/mach-davinci/include/mach/dm644x.h @@ -6,8 +6,7 @@ * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. + * the Free Software Foundation; either version 2 of the License.
Unfinished sentence. Did you intend to changed the license to GPL 2 only? If so, it's worth mentioning in the changelog... [...]
@@ -40,8 +43,21 @@ #define DM644X_ASYNC_EMIF_DATA_CE2_BASE 0x06000000 #define DM644X_ASYNC_EMIF_DATA_CE3_BASE 0x08000000 +/* VPBE register base addresses */ +#define DM644X_VENC_REG_BASE 0x01C72400
You defined the macro but don't use it...
+#define DM644X_VPBE_REG_BASE 0x01C72780 + +#define DM644X_OSD_REG_BASE 0x01C72600
Same comment...
+#define DM644X_VPBE_REG_BASE 0x01C72780
This is duplicate.
+ +#define OSD_REG_SIZE 0x00000100
Your OSD platform device however has its resource of size 0x200...
+/* SYS register addresses */ +#define SYS_VPSS_CLKCTL 0x01C40044
You've already #define'd and used VPSS_CLKCTL -- this is duplicate/unused. WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
