Hello. On 10-01-2011 13:23, Manjunath Hadli wrote:
This patch implements the overall device creation for the Video display driver.
Signed-off-by: Manjunath Hadli<[email protected]> Acked-by: Muralidharan Karicheri<[email protected]> Acked-by: Hans Verkuil<[email protected]>
[...]
diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c index 9a2376b..3cc5f7c 100644 --- a/arch/arm/mach-davinci/dm644x.c +++ b/arch/arm/mach-davinci/dm644x.c
[...]
@@ -654,6 +655,138 @@ void dm644x_set_vpfe_config(struct vpfe_config *cfg)
[...]
+ +#define VPSS_CLKCTL SYS_VPSS_CLKCTL
What's the point? Why not just use SYS_VPSS_CLKCTL?
diff --git a/arch/arm/mach-davinci/include/mach/dm644x.h b/arch/arm/mach-davinci/include/mach/dm644x.h index 5a1b26d..46385e7 100644 --- a/arch/arm/mach-davinci/include/mach/dm644x.h +++ b/arch/arm/mach-davinci/include/mach/dm644x.h
[...]
@@ -40,8 +43,19 @@ #define DM644X_ASYNC_EMIF_DATA_CE2_BASE 0x06000000 #define DM644X_ASYNC_EMIF_DATA_CE3_BASE 0x08000000 +/* VPBE register base addresses */ +#define DM644X_VENC_REG_BASE 0x01C72400 +#define DM644X_OSD_REG_BASE 0x01C72600 + +#define OSD_REG_SIZE 0x000001ff +#define VENC_REG_SIZE 0x0000017f
Well, actually that's not the size but "limit" -- sizes should be 0x200 and 0x180 respectively...
WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
