Hello.
On 02-02-2011 16:10, subhasish wrote:
You have strange manner of replying -- please don't quote your own words...
Sergei Shtylyov-2 wrote:
2?
This patch adds the platform device and assignes the platform resources
for the PRUSS mfd driver.
Signed-off-by: Subhasish Ghosh<[email protected]>
[...]
diff --git a/arch/arm/mach-davinci/da850.c
b/arch/arm/mach-davinci/da850.c
index 3443d97..341d836 100644
--- a/arch/arm/mach-davinci/da850.c
+++ b/arch/arm/mach-davinci/da850.c
@@ -238,6 +238,12 @@ static struct clk tptc2_clk = {
.flags = ALWAYS_ENABLED,
};
+static struct clk pruss_clk = {
+ .name = "pruss",
+ .parent = &pll0_sysclk2,
+ .lpsc = DA8XX_LPSC0_DMAX,
IIRC, you were asked to change/add a new name for what is known as
DA8XX_LPSC0_DMAX...
[SG] This macro is also getting used by arch/arm/mach-davinci/da830.c.
Hence, changing this is breaking the da830 build. Not sure how to go about
it.
I suspect that dMAX is specific to DA830, and PRUSS is specific to DA850.
Therefore I think you should add the DA850_LPSC0_PRUSS definition (and
probably change from DA8XX_LPSC0_DMAX to DA830_LPSC0_DMAX) with another patch.
diff --git a/arch/arm/mach-davinci/devices-da8xx.c
b/arch/arm/mach-davinci/devices-da8xx.c
index beda8a4..562882c 100644
--- a/arch/arm/mach-davinci/devices-da8xx.c
+++ b/arch/arm/mach-davinci/devices-da8xx.c
+struct platform_device da8xx_pruss_dev = {
+ .name = "da8xx_pruss",
+ .id = -1,
+ .num_resources = ARRAY_SIZE(da8xx_pruss_resources),
+ .resource = da8xx_pruss_resources,
Please align = uniformly.
[SG] -- I think the problem is the tabs stops. I use ts=4, but, I think
the web displays as ts=8. When I looked into other platform files, I
noticed that many other macros/initializers get aligned/misaligned if I
change between ts=4 and ts=8.
Just always use ts=8.
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
