hi Sekhar,

On Thu, Feb 3, 2011 at 1:17 PM, Nori, Sekhar <[email protected]> wrote:

> >                  diff --git a/arch/arm/mach-davinci/Kconfig
> >                  b/arch/arm/mach-davinci/Kconfig
> >                  index 32f1479..e13b7e0 100644
> >                  --- a/arch/arm/mach-davinci/Kconfig
> >                  +++ b/arch/arm/mach-davinci/Kconfig
> >                  @@ -213,6 +213,16 @@ config MACH_MITYOMAPL138
> >                   config MACH_OMAPL138_HAWKBOARD
> >                         bool "TI AM1808 / OMAPL-138 Hawkboard
> > platform"
> >                         depends on ARCH_DAVINCI_DA850
> >                  +       select MTD
> >                  +       select MTD_PARTITIONS
> >                  +       select MTD_CHAR
> >                  +       select MTD_BLKDEVS
> >                  +       select MTD_BLOCK
> >                  +       select MTD_PHYSMAP
> >                  +       select MTD_CFI
> >
> >
> >
> >               I don't think CFI is necessary for NAND?
> >
> >
> >
> >         Neither is the 'physmap' driver. And all this part of the
> > patch looks completely bogus.
> >
> >
> >
> > I think MTD_CFI and MTD_PHYSMAP are not needed. I need the rest of the
> > options for mtd related stuff. I guess i can include these in the same
> > patch. Will come up with an updated revision. Thanks.
>
> Why do you need to select these through Kconfig. Why cant these
> be enabled/disabled by users using menuconfig?
>

Since the hawkboard comes with a default Nand chip, i thought these could be
part of the default config. But i see that these configs are not defined for
for other ARM boards(except PXA). In that case, i can remove these configs
from the deault. Thanks.

-sughosh
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to