Hi Sekhar, On 2/2/2011 10:37 AM, Nori, Sekhar wrote:
> Hi Mike, > > On Wed, Feb 02, 2011 at 20:18:39, Michael Williamson wrote: > >>> Since all the platform device definitions for DA8XX devices happens >>> in devices-da8xx.c, it makes sense to get rid of the DA830_DMACH_* >>> enum altogether and instead just define the channel numbers used in >>> devices-da8xx.c above the actual usage. >>> >>> Mike, is that something you are willing take-up? >>> >> >> >> I can take this up as a separate patch series. I'd like to keep the >> spi platform support series isolated to that subject matter, if that's >> OK. > > Yes, the clean-up can be a separate series - but it will have to > precede the SPI series. > Quick question: In addition to cleaning up the enums in edma.h, are you also asking to pull the channel / base resources for ASP currently defined in asp.h into devices-da8xx.c as well? Or should that be left alone? E.G., these defines look like they should go in devices-da8xx and come out of asp.h: DAVINCI_DA8XX_MCASP0_REG_BASE DAVINCI_DA830_MCASP1_REG_BASE DAVINCI_DA8XX_DMA_MCASP0_AREVT DAVINCI_DA8XX_DMA_MCASP0_AXEVT DAVINCI_DA830_DMA_MCASP1_AREVT DAVINCI_DA830_DMA_MCASP1_AXEVT If moved, there are other #defines that should then be shuffled out of asp.h to other files for other chips/platforms for completeness, E.G. DAVINCI_DM646X_DMA_MCASP0_AXEVT0 should go to dm646x.c. I'm not too keen on shuffling stuff around like that if I can't test it beyond compiling. Especially if it's not adding any functionality. But, I will submit it if it's necessary to get the SPI support in. Thanks. -Mike _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
