Ok, will do.

--------------------------------------------------
From: "Sergei Shtylyov" <[email protected]>
Sent: Tuesday, February 22, 2011 4:50 PM
To: "Subhasish Ghosh" <[email protected]>
Cc: <[email protected]>; <[email protected]>; "Russell King" <[email protected]>; "Kevin Hilman" <[email protected]>; <[email protected]>; "open list" <[email protected]>; <[email protected]>; <[email protected]> Subject: Re: [PATCH v2 12/13] da850: pruss SUART platform specific additions.

Hello.

On 22-02-2011 12:18, Subhasish Ghosh wrote:

I could not follow your recommendations clearly, are you suggesting this:

int __init da8xx_register_pruss(struct da8xx_pruss_devices *pruss_device)
{
#ifdef CONFIG_SERIAL_PRUSS_SUART_MODULE
int ret;

ret = clk_add_alias(NULL, "da8xx_pruss_uart.1",
NULL, &da850_mcasp_device.dev);
if (ret < 0)
return ret;
#endif
da8xx_pruss_dev.dev.platform_data = pruss_device;
return platform_device_register(&da8xx_pruss_dev);
}

Yes. But still better would be to wrap clk_add_alias() into a function of its own (defining it empty if CONFIG_SERIAL_PRUSS_SUART_MODULE is not defined).

WBR, Sergei

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to