Hi, > -----Original Message----- > From: Hans J. Koch [mailto:[email protected]] > Sent: Tuesday, March 01, 2011 2:57 AM > To: TK, Pratheesh Gangadhar > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; Chatterjee, Amit; > [email protected]; linux-arm- > [email protected] > Subject: Re: [PATCH v6 1/1] PRUSS UIO driver support > > On Tue, Mar 01, 2011 at 02:31:35AM +0530, Pratheesh Gangadhar wrote: > > + > > + /* Register PRUSS IRQ lines */ > > + p->irq = IRQ_DA8XX_EVTOUT0 + cnt; > > + p->handler = pruss_handler; > > + > > + ret = uio_register_device(&dev->dev, p); > > + > > + if (ret < 0) > > + goto out_free; > > + } > > + > > + spin_lock_init(&lock); > > That's too late. uio_register_device() enables the irq, and your spin_lock > is not ready at that time.
This is ok in this context as "modprobe uio_pruss" is pre-requisite for running PRUSS firmware and without firmware running PRUSS won't generate interrupts. Actually PRUSS INTC is not setup till we start user application. Thanks, Pratheesh _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
