On Mon, May 23, 2011 at 13:58:26, Nori, Sekhar wrote: > On Fri, May 20, 2011 at 20:02:08, Sergei Shtylyov wrote: > > Hello. > > > > Manjunath Hadli wrote: > > > > > This patch adds the build infra-structure for Davinci VPBE dislay > > > driver. > > > > > Signed-off-by: Manjunath Hadli <[email protected]> > > > Acked-by: Muralidharan Karicheri <[email protected]> > > > Acked-by: Hans Verkuil <[email protected]> > > [...] > > > > > diff --git a/drivers/media/video/davinci/Kconfig > > > b/drivers/media/video/davinci/Kconfig > > > index 6b19540..a7f11e7 100644 > > > --- a/drivers/media/video/davinci/Kconfig > > > +++ b/drivers/media/video/davinci/Kconfig > > > @@ -91,3 +91,25 @@ config VIDEO_ISIF > > > > > > To compile this driver as a module, choose M here: the > > > module will be called vpfe. > > > + > > > +config VIDEO_DM644X_VPBE > > > + tristate "DM644X VPBE HW module" > > > > BTW, as this seems DM644x specific, shouldn't this depend on > > CONFIG_ARCH_DAVINCI_DM644x? > > Since VENC/OSD etc are also applicable to other DaVinci devices, this KConfig > entry should probably be split to refer to them individually and in a generic > way. "depends on" can then be used to make sure only the relevant ones show > up.
Both venc and osd have to be used together always, so might not make a good idea to split. However, I will add a dependency on DM644x, and include others with appropriate patch sets. > > Thanks, > Sekhar > > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
