Sergei,
I had replied to your earlier comment.
>> __raw_writel(mdctl, psc_base + MDCTL + 4 * id);
>>
>> pdstat = __raw_readl(psc_base + PDSTAT);
>> - if ((pdstat & 0x00000001) == 0) {
The current code doesn't make much sense to me -- Kevin, as the original
author, could you explain why this cross-dependency between domains 0 and 1?
The code below should never be executed in my opinion, since domain 0 is
always-on, so 'pdstat & 1' should never be 0 -- although my DA830 manual says
it's 0 by default even though PDSTAT0.NEXT is initially 1...
I could understand if we had:
if (domain) {
instead if this check...
And the bit mask certainly isn't right as it excludes the "intermediate
state" bit 4.
[MK] This will be corrected in my next revision of the patch. But would wait to
hear response from Kevin as well.
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
