Sergei, On Wed, Dec 14, 2011 at 16:18:40, Sergei Shtylyov wrote: > Hello. > > On 13-12-2011 15:23, Manjunath Hadli wrote: > > > Create platform devices for various video modules like venc,osd, vpbe > > and v4l2 driver for dm644x. Change the dm644x_init_video to make room > > for display config, and register the vpfe or vpbe devices based on the > > config pointer validity to make sure boards without vpfe or vpbe can > > be built with minimal changes. > > > Signed-off-by: Manjunath Hadli<[email protected]> > [...] > > > diff --git a/arch/arm/mach-davinci/dm644x.c > > b/arch/arm/mach-davinci/dm644x.c index 6c034fd..2e408d8 100644 > > --- a/arch/arm/mach-davinci/dm644x.c > > +++ b/arch/arm/mach-davinci/dm644x.c > [...] > > @@ -654,7 +654,127 @@ static struct platform_device dm644x_vpfe_dev = > > { > [...] > > +#define DM644X_OSD_REG_BASE 0x01c72600 > [...] > > +#define DM644X_VENC_REG_BASE 0x01c72400 > > Why not without _REG, like all the other #define's? Ok. > > > +static int dm644x_venc_setup_clock(enum vpbe_enc_timings_type type, > > + unsigned int mode) > > +{ > > + int ret = 0; > > + void __iomem *vpss_clkctl_reg; > > + > > + vpss_clkctl_reg = DAVINCI_SYSMODULE_VIRT(0x44); > > Why not in the initializer? Because it is used only for clock control. I think it is fine here. > > > + switch (type) { > > + case VPBE_ENC_STD: > > + writel(0x18, vpss_clkctl_reg); > > + break; > > + case VPBE_ENC_DV_PRESET: > > + switch ((unsigned int)mode) { > > 'mode' is already 'unsigned int'. Ok. Thx, -Manju > > WBR, Sergei > >
_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
