Hi Sergei, On Tue, Dec 20, 2011 at 16:37:16, Sergei Shtylyov wrote: > Hello. > > On 20.12.2011 10:36, Manjunathappa, Prakash wrote: > > > From: Ajay Kumar Gupta <[email protected]> > > It's a good practice to CC the original author of the patch -- which I'm > doing now... >
I did put author and maintainers in CC, my git send-email log shows it up as below. But I don't know why it doesnot appear when mails reach my inbox. Can you please let me know if I am missing any configuration?: prakash@linux-psp-server:~/project/linux/linux_torvalds$ git send-email --smtp-server=192.168.247.13 [email protected] [email protected] [email protected] [email protected] 0001-davinci-DA850-EVM-OHCI-platform-code.patch 0001-davinci-DA850-EVM-OHCI-platform-code.patch Who should the emails appear to be from? [Manjunathappa, Prakash <[email protected]>] Emails will be sent from: Manjunathappa, Prakash <[email protected]> Who should the emails be sent to? [email protected] Message-ID to be used as In-Reply-To for the first email? (mbox) Adding cc: Ajay Kumar Gupta <[email protected]> from line 'From: Ajay Kumar Gupta <[email protected]>' (body) Adding cc: Ajay Kumar Gupta <[email protected]> from line 'Signed-off-by: Ajay Kumar Gupta <[email protected]>' From: "Manjunathappa, Prakash" <[email protected]> To: [email protected] Cc: [email protected], [email protected], [email protected], [email protected], Ajay Kumar Gupta <[email protected]> Subject: [PATCH] davinci: DA850 EVM: OHCI platform code Date: Wed, 21 Dec 2011 11:05:38 +0530 Message-Id: <[email protected]> X-Mailer: git-send-email 1.7.1 The Cc list above has been expanded by additional addresses found in the patch commit message. By default send-email prompts before sending whenever this occurs. This behavior is controlled by the sendemail.confirm configuration setting. For additional information, run 'git send-email --help'. To retain the current behavior, but squelch this message, run 'git config --global sendemail.confirm auto'. Send this email? ([y]es|[n]o|[q]uit|[a]ll): > > On this board the OHCI port's power control and over-current signals from > > TPS2065 power switch are connected via GPIO1[15] and GPIO2[1] respectively, > > Ajay, your description seems to be copied unchganged from the analogous > DA830 EVM patch, and thus doesn't match your patch: GPIO2[4] and GPIO6[13] > are > used apparently. Be more attentive to detail next time please. > I will fix this. > > so we can implement the DA8xx OHCI glue layer's hooks for overriding the > > root hub port's power and over-current status bits. > > > We also have to properly set up the clocking mode in the CFGCHIP2 register, > > so that internal 24 MHz reference clock is fed to the USB 2.0 (MUSB) PHY and > > its output is used to clock the USB 1.1 (OHCI) PHY... > > > Signed-off-by: Ajay Kumar Gupta <[email protected]> > > --- > > arch/arm/mach-davinci/board-da850-evm.c | 126 > > +++++++++++++++++++++++++++++++ > > 1 files changed, 126 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-davinci/board-da850-evm.c > > b/arch/arm/mach-davinci/board-da850-evm.c > > index 6659a90..df74ba5 100644 > > --- a/arch/arm/mach-davinci/board-da850-evm.c > > +++ b/arch/arm/mach-davinci/board-da850-evm.c > [...] > > @@ -734,6 +736,127 @@ static struct davinci_i2c_platform_data > > da850_evm_i2c_0_pdata = { > [...] > > +static int da850_evm_usb_ocic_notify(da8xx_ocic_handler_t handler) > > +{ > > + int irq = gpio_to_irq(ON_BD_USB_OVC); > > + int error = 0; > > + > > + if (handler != NULL) { > > + da850_evm_usb_ocic_handler = handler; > > + > > + error = request_irq(irq, da850_evm_usb_ocic_irq, IRQF_DISABLED | > > IRQF_DISABLED is a nop now -- just remove it. > Agreed, I will remove it. Thanks, Prakash > WBR, Sergei > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
