>> -----Original Message----- >> From: Linus Walleij [mailto:[email protected]] >> Sent: Wednesday, September 26, 2012 7:11 AM >> To: Karicheri, Muralidharan >> Cc: [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; linux- >> [email protected]; Nori, Sekhar; Hilman, Kevin; [email protected]; >> davinci- >> [email protected]; >> [email protected]; linux- >> [email protected] - Linux developers for Keystone family of devices (May >> contain non- >> TIers); [email protected]; Chemparathy, Cyril >> Subject: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci - add Main PLL >> clock driver >> >> On Tue, Sep 25, 2012 at 12:20 AM, Murali Karicheri <[email protected]> >> wrote: >> >> > +struct clk_davinci_pll_data { >> > + /* physical addresses set by platform code */ >> > + u32 phy_pllm; >> > + /* if PLL has a prediv register this should be non zero */ >> > + u32 phy_prediv; >> > + /* if PLL has a postdiv register this should be non zero */ >> > + u32 phy_postdiv; >> > + /* mapped addresses. should be initialized by */ >> > + void __iomem *pllm; >> > + void __iomem *prediv; >> > + void __iomem *postdiv; >> > + u32 pllm_mask; >> > + u32 prediv_mask; >> > + u32 postdiv_mask; >> > + u32 num; >> > + /* framework flags */ >> > + u32 flags; >> > + /* pll flags */ >> > + u32 pll_flags; >> > + u32 fixed_prediv; /* use this value for prediv */ >> > + u32 pllm_multiplier; /* multiply PLLM by this factor. By default >> > + * most SOC set this to zero that >> > translates >> > + * to a multiplier of 1 and incrementer of >> > 1. >> > + * To override default, set this factor */ >> > +}; >> >> OMG this commenting style hurt my eyes ;-) >> >> Please use good old kerneldoc above the struct instead. >> >> Yours, >> Linus Walleij
Sure! I will fix these in my next revision. Murali _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
