Hi Sekhar, thanks for reviewing this, please see below questions...
> -----Original Message-----
> From: Nori, Sekhar
> Sent: Friday, October 12, 2012 6:06 AM
> To: Tivy, Robert
> Cc: [email protected]; Ring, Chris;
> Grosen, Mark
> Subject: Re: [PATCH 1/2] ARM: davinci: Changed pr_warning() to
> pr_warn()
>
> Hi Rob,
>
> On 9/19/2012 5:57 AM, Robert Tivy wrote:
> > From: Robert Tivy <[email protected]>
> >
> > According to checkpatch.pl, source code should use pr_warn instead of
> > pr_warning.
> >
> > Signed-off-by: Robert Tivy <[email protected]>
>
> Thanks for the patch. Since you are touching all these prints, can you
> also fix hardcoding of function name instead of using __func__ where
> ever that occurs? While doing that, please check if any of the line
> breaks can now be killed.
As I was going through board-da850-evm.c I came to suspect that the reason some
of the function names were hardcoded was because the printed function name did
not match the actual function name from where the pr_*() was called and because
the author perhaps wanted them all to appear as though they originated from
da850_evm_init() (and I believe all those functions are called by only
da850_evm_init()). The pr_*() calls that actually do originate in
da850_evm_init() can certainly have more compact strings by using pr_warn("%s
...", __func__), but I wonder about the others.
Do you still recommend changing all of them to use __func__, or just the ones
that have hardcoded function names that match the calling function?
>
> Please copy [email protected] on your submissions
> touching arch/arm/*.
>
> While sending patches using git-send-email, please send 1/2 and 2/2
> together. This will make them appear in the same thread.
I used "sendmail" with some header fields manually added to a git-produced
patch file. How does one cause two separate emails to appear in the same
thread?
Thanks & Regards,
- Rob
>
> Thanks,
> Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
