On Sun, Feb 03, 2013 at 18:19:05, Nori, Sekhar wrote:
>
>
> On 1/29/2013 1:08 PM, Vishwanathrao Badarkhe, Manish wrote:
> > Add I2C0 device tree node information to da850-evm.
> > Also, add I2C0 pin muxing information in da850-evm.
> >
> > Signed-off-by: Vishwanathrao Badarkhe, Manish <manish...@ti.com>
> > ---
> > Changes since V1:
> > - Updated i2c0 node names in dts and dtsi file.
> > - Removed interrupt parent from i2c0 node.
> > - Handled i2c0 pin mux inside i2c0 node.
> >
> > :100644 100644 433027f... c9ed683... M arch/arm/boot/dts/da850-evm.dts
> > :100644 100644 5e0eb5c... 245ab9a... M arch/arm/boot/dts/da850.dtsi
> > arch/arm/boot/dts/da850-evm.dts | 5 +++++
> > arch/arm/boot/dts/da850.dtsi | 15 +++++++++++++++
> > 2 files changed, 20 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/da850-evm.dts
> > b/arch/arm/boot/dts/da850-evm.dts index 433027f..c9ed683 100644
> > --- a/arch/arm/boot/dts/da850-evm.dts
> > +++ b/arch/arm/boot/dts/da850-evm.dts
> > @@ -27,6 +27,11 @@
> > serial2: serial@1d0d000 {
> > status = "okay";
> > };
> > + i2c0: i2c0@1c22000 {
>
> This should be:
>
> i2c0: i2c@1c22000
>
> inline with what has been done in rest of this file.
Ok, I will update this name everywhere.
>
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c0_pins>;
> > + };
> > };
> > nand_cs3@62000000 {
> > status = "okay";
> > diff --git a/arch/arm/boot/dts/da850.dtsi
> > b/arch/arm/boot/dts/da850.dtsi index 5e0eb5c..245ab9a 100644
> > --- a/arch/arm/boot/dts/da850.dtsi
> > +++ b/arch/arm/boot/dts/da850.dtsi
> > @@ -56,6 +56,12 @@
> > 0x30 0x01100000 0x0ff00000
> > >;
> > };
> > + i2c0_pins: pinmux_i2c0_pins {
> > + pinctrl-single,bits = <
> > + /* I2C0_SDA,I2C0_SCL */
> > + 0x10 0x00002200 0x0000ff00
> > + >;
> > + };
> > };
> > serial0: serial@1c42000 {
> > compatible = "ns16550a";
> > @@ -81,6 +87,15 @@
> > interrupts = <61>;
> > status = "disabled";
> > };
> > + i2c0: i2c0@1c22000 {
> > + compatible = "ti,davinci-i2c";
> > + reg = <0x22000 0x1000>;
> > + clock-frequency = <100000>;
>
> The clock frequency is board specific. This should come from da850-evm.dts.
Ok, I will add this board specific information in da850-evm.dts.
>
> Also, I think you can merge the auxdata addition with this patch. Can you
> post the i2c0 support separate from this series, so it can be taken
> independently? Looks like other patches have some dependencies/acks needed.
Sure, I will merge auxdata addition with this patch and post this patch
independently from this series.
>
> Thanks,
> Sekhar
>
Regards,
Manish
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
