Hi Prabhakar, On 01/28/2013 12:50 PM, Prabhakar Lad wrote: > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 0ef8833..dac06d7 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -56,6 +56,8 @@ struct media_device_info { > #define MEDIA_ENT_T_V4L2_SUBDEV_SENSOR (MEDIA_ENT_T_V4L2_SUBDEV + 1) > #define MEDIA_ENT_T_V4L2_SUBDEV_FLASH (MEDIA_ENT_T_V4L2_SUBDEV + 2) > #define MEDIA_ENT_T_V4L2_SUBDEV_LENS (MEDIA_ENT_T_V4L2_SUBDEV + 3) > +/* DECODER: Converts analogue video to digital */
The patch looks good to me, I would just change this comment to something like: /* A converter of analogue video to its digital representation. */ But that's really a nitpicking. > +#define MEDIA_ENT_T_V4L2_SUBDEV_DECODER (MEDIA_ENT_T_V4L2_SUBDEV + 4) > > #define MEDIA_ENT_FL_DEFAULT (1 << 0) Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Thanks, Sylwester _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source