On Mon, Nov 18, 2013 at 02:11:32PM +0100, Linus Walleij wrote:
> On Fri, Nov 8, 2013 at 11:11 AM, Prabhakar Lad
> <prabhakar.cse...@gmail.com> wrote:
>
> > From: "Lad, Prabhakar" <prabhakar.cse...@gmail.com>
> >
> > This patch converts the davinci gpio driver to use irqdomain
> > support.
> >
> > Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com>
>
> (...)
> > @@ -282,8 +283,7 @@ gpio_irq_handler(unsigned irq, struct irq_desc *desc)
> > desc->irq_data.chip->irq_ack(&desc->irq_data);
> > while (1) {
> > u32 status;
> > - int n;
> > - int res;
> > + int bit;
>
> Why is this an int? I think u8 would suffice.
For local variables, it's better to use "int" or even "unsigned" here
rather than u8. u8 tells the compiler that you want the variable to be
8-bit, which seems fine, except the compiler is then at liberty to keep
on masking the register back down to 8-bit.
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
