On Thursday 20 March 2014 12:59 AM, Arnd Bergmann wrote: > The DAVINCI_DA850_EVM board uses an unusual method to > enable the GPIO_PCA953X and KEYBOARD_GPIO_POLLED symbols, > which leads to the dependencies on these symbols being > ignored. As GPIO_PCA953X actually requires I2C, that > can lead to build failures when I2C is disabled. > > This patch removes the duplicate symbol definitions
I am okay with this.. > and instead adds equivalent 'select' statements that > are conditional on the underlying dependencies. .. but not sure this is needed. The PCA953X was defaulted to y mainly because the IO expander was used to detect presence of daughter cards. Even then, I don't think there is any need to force its selection. > > A different question whether we actually want to automatically > enable them at all or rather put them into defconfig, > but that should be a separate patch. It can be enabled through defconfig as you said. I agree that can be a separate patch. For now, just dropping the replicated Kconfig symbols should be okay. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
