To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=55893
User fs changed the following:
What |Old value |New value
================================================================================
Status|RESOLVED |VERIFIED
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed Feb 22 03:55:57 -0800
2006 -------
VERIFIED the patch made it into the CWS.
fs->mmeeks:
Patch looks good, however I didn't check the functionality, I assume you did :)
Two comments:
- OOo has an own diagnostics system (well, actually two :(, but that's another
story),
so please in future use this one (DBG_ASSERT/DBG_WARNING resp.
OSL_ENSURE/OSL_WARNING) instead of g_warning.
- Your editor seems to have set a tab width of 8. Convention for OOo source
files
(and surely written down in the Code Guidelines, though I didn't check :) is
4. Please respect this in future patches, else the code becomes unreadable in
the
editors of nearly all other developers.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
