Tag: cws_src680_warnings01
User: fs      
Date: 06/06/14 00:29:17

Modified:
 /dba/connectivity/source/drivers/file/
  FDatabaseMetaData.cxx

Log:
 during #i66362#: easiert construction of ODatabaseMetaDataResultSet

File Changes:

Directory: /dba/connectivity/source/drivers/file/
=================================================

File [changed]: FDatabaseMetaData.cxx
Url: 
http://dba.openoffice.org/source/browse/dba/connectivity/source/drivers/file/FDatabaseMetaData.cxx?r1=1.30.30.4&r2=1.30.30.5
Delta lines:  +19 -65
---------------------
--- FDatabaseMetaData.cxx       22 Dec 2005 11:44:43 -0000      1.30.30.4
+++ FDatabaseMetaData.cxx       14 Jun 2006 07:29:15 -0000      1.30.30.5
@@ -4,9 +4,9 @@
  *
  *  $RCSfile: FDatabaseMetaData.cxx,v $
  *
- *  $Revision: 1.30.30.4 $
+ *  $Revision: 1.30.30.5 $
  *
- *  last change: $Author: fs $ $Date: 2005/12/22 11:44:43 $
+ *  last change: $Author: fs $ $Date: 2006/06/14 07:29:15 $
  *
  *  The Contents of this file are made available subject to
  *  the terms of GNU Lesser General Public License Version 2.1.
@@ -111,19 +111,12 @@
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTypeInfo(  ) 
throw(SQLException, RuntimeException)
 {
-       ::osl::MutexGuard aGuard( m_aMutex );
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setTypeInfoMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eTypeInfo );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getCatalogs(  ) 
throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setCatalogsMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eCatalogs );
 }
 // -------------------------------------------------------------------------
 ::rtl::OUString SAL_CALL ODatabaseMetaData::getCatalogSeparator(  ) 
throw(SQLException, RuntimeException)
@@ -133,20 +126,14 @@
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getSchemas(  ) 
throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setSchemasMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eSchemas );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getColumnPrivileges(
         const Any& /*catalog*/, const ::rtl::OUString& /*schema*/, const 
::rtl::OUString& /*table*/,
         const ::rtl::OUString& /*columnNamePattern*/ ) throw(SQLException, 
RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setColumnPrivilegesMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eColumnPrivileges );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getColumns(
@@ -154,10 +141,7 @@
         const ::rtl::OUString& /*columnNamePattern*/ ) throw(SQLException, 
RuntimeException)
 {
        OSL_ENSURE(0,"Should be overloaded!");
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setColumnsMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eColumns );
 }
 
 // -------------------------------------------------------------------------
@@ -257,9 +241,8 @@
        ::osl::MutexGuard aGuard( m_aMutex );
 
 
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
+    ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eTables );
     Reference< XResultSet > xRef = pResult;
-       pResult->setTablesMap();
 
        // check if any type is given
        // when no types are given then we have to return all tables e.g. TABLE
@@ -405,29 +388,20 @@
         const Any& /*catalog*/, const ::rtl::OUString& /*schemaPattern*/,
         const ::rtl::OUString& /*procedureNamePattern*/, const 
::rtl::OUString& /*columnNamePattern*/ ) throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setProcedureColumnsMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eProcedureColumns );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getProcedures(
         const Any& /*catalog*/, const ::rtl::OUString& /*schemaPattern*/,
         const ::rtl::OUString& /*procedureNamePattern*/ ) throw(SQLException, 
RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setProceduresMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eProcedures );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getVersionColumns(
         const Any& /*catalog*/, const ::rtl::OUString& /*schema*/, const 
::rtl::OUString& /*table*/ ) throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setVersionColumnsMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eVersionColumns );
 }
 // -------------------------------------------------------------------------
 sal_Int32 SAL_CALL ODatabaseMetaData::getMaxBinaryLiteralLength(  ) 
throw(SQLException, RuntimeException)
@@ -493,48 +467,33 @@
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getExportedKeys(
         const Any& /*catalog*/, const ::rtl::OUString& /*schema*/, const 
::rtl::OUString& /*table*/ ) throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setExportedKeysMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eExportedKeys );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getImportedKeys(
         const Any& /*catalog*/, const ::rtl::OUString& /*schema*/, const 
::rtl::OUString& /*table*/ ) throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setImportedKeysMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eImportedKeys );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getPrimaryKeys(
         const Any& /*catalog*/, const ::rtl::OUString& /*schema*/, const 
::rtl::OUString& /*table*/ ) throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setPrimaryKeysMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::ePrimaryKeys );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getIndexInfo(
         const Any& /*catalog*/, const ::rtl::OUString& /*schema*/, const 
::rtl::OUString& /*table*/,
         sal_Bool /*unique*/, sal_Bool /*approximate*/ ) throw(SQLException, 
RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setIndexInfoMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eIndexInfo );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getBestRowIdentifier(
         const Any& /*catalog*/, const ::rtl::OUString& /*schema*/, const 
::rtl::OUString& /*table*/, sal_Int32 /*scope*/,
         sal_Bool /*nullable*/ ) throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setBestRowIdentifierMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eBestRowIdentifier );
 }
 // -------------------------------------------------------------------------
 Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTablePrivileges(
@@ -542,9 +501,8 @@
 {
        ::osl::MutexGuard aGuard( m_aMutex );
 
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
+    ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eTablePrivileges );
     Reference< XResultSet > xRef = pResult;
-       pResult->setTablePrivilegesMap();
        ODatabaseMetaDataResultSet::ORows aRows;
 
 
@@ -612,10 +570,7 @@
         const ::rtl::OUString& /*primaryTable*/, const Any& /*foreignCatalog*/,
         const ::rtl::OUString& /*foreignSchema*/, const ::rtl::OUString& 
/*foreignTable*/ ) throw(SQLException, RuntimeException)
 {
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
-    Reference< XResultSet > xRef = pResult;
-       pResult->setCrossReferenceMap();
-       return xRef;
+    return new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eCrossReference );
 }
 // -------------------------------------------------------------------------
 sal_Bool SAL_CALL ODatabaseMetaData::doesMaxRowSizeIncludeBlobs(  ) 
throw(SQLException, RuntimeException)
@@ -808,9 +763,8 @@
 {
        ::osl::MutexGuard aGuard( m_aMutex );
 
-       ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet();
+    ODatabaseMetaDataResultSet* pResult = new ODatabaseMetaDataResultSet( 
ODatabaseMetaDataResultSet::eTableTypes );
     Reference< XResultSet > xRef = pResult;
-       pResult->setTableTypes();
        static ODatabaseMetaDataResultSet::ORows aRows;
        if(aRows.empty())
        {




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to