User: kz      
Date: 2008-03-05 17:30:43+0000
Modified:
   dba/reportdesign/java/com/sun/star/report/pentaho/StarReportData.java

Log:
 INTEGRATION: CWS rptchart01_DEV300 (1.2.70); FILE MERGED
 2008/02/21 09:57:23 oj 1.2.70.1: #i85225# fixes found with PMD

File Changes:

Directory: /dba/reportdesign/java/com/sun/star/report/pentaho/
==============================================================

File [changed]: StarReportData.java
Url: 
http://dba.openoffice.org/source/browse/dba/reportdesign/java/com/sun/star/report/pentaho/StarReportData.java?r1=1.2&r2=1.3
Delta lines:  +130 -131
-----------------------
--- StarReportData.java 2007-07-09 11:56:04+0000        1.2
+++ StarReportData.java 2008-03-05 17:30:40+0000        1.3
@@ -33,8 +33,6 @@
  *    MA  02111-1307  USA
  *
  ************************************************************************/
-
-
 package com.sun.star.report.pentaho;
 
 import com.sun.star.report.DataSource;
@@ -43,11 +41,12 @@
 
 public class StarReportData implements ReportData
 {
+
   private DataSource dataSource;
   private int currentRow;
   private int rowCount;
 
-  public StarReportData (final DataSource dataSource)
+    public StarReportData(final DataSource dataSource)
           throws com.sun.star.report.DataSourceException
   {
     if (dataSource == null)
@@ -63,12 +62,12 @@
   {
     try
     {
-      if (dataSource.absolute(row))
+            boolean ret = dataSource.absolute(row);
+            if (ret)
       {
         currentRow = row;
-        return true;
       }
-      return false;
+            return ret;
     }
     catch (com.sun.star.report.DataSourceException e)
     {
@@ -76,7 +75,7 @@
     }
   }
 
-  public void close ()
+    public void close()
           throws DataSourceException
   {
     try
@@ -89,7 +88,7 @@
     }
   }
 
-  public int getCursorPosition ()
+    public int getCursorPosition()
           throws DataSourceException
   {
     return currentRow;
@@ -108,7 +107,7 @@
     return currentRow  < rowCount;
   }
 
-  public boolean next ()
+    public boolean next()
           throws DataSourceException
   {
     try
@@ -126,7 +125,7 @@
     }
   }
 
-  public Object get (final int column)
+    public Object get(final int column)
           throws DataSourceException
   {
     if (isReadable() == false)
@@ -144,7 +143,7 @@
     }
   }
 
-  public int getColumnCount ()
+    public int getColumnCount()
           throws DataSourceException
   {
     try
@@ -157,7 +156,7 @@
     }
   }
 
-  public String getColumnName (final int column)
+    public String getColumnName(final int column)
           throws DataSourceException
   {
     try




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to