Author: byterock
Date: Tue Jun 24 08:07:58 2008
New Revision: 11450
Modified:
dbd-oracle/trunk/Changes
dbd-oracle/trunk/MANIFEST
dbd-oracle/trunk/Makefile.PL
dbd-oracle/trunk/dbdimp.c
dbd-oracle/trunk/oci8.c
Log:
Added patch to fix a number of harmless, but annoying, GCC warnings from Eric
Simon
Modified: dbd-oracle/trunk/Changes
==============================================================================
--- dbd-oracle/trunk/Changes (original)
+++ dbd-oracle/trunk/Changes Tue Jun 24 08:07:58 2008
@@ -1,4 +1,5 @@
=head1 Changes in DBD-Oracle 1.22(svn rev xxxx) 2008
+ Added patch to fix a number of harmless, but annoying, GCC warnings from
Eric Simon
Added (finally) ora_verbose for DBD only tracking from John Scoles and
thanks to H.Merijn Brand
Fix for rt.cpan.org Ticket #=32396 from John Scoles
Fix for memory leak that snuck into 1.21 from John Scoles
Modified: dbd-oracle/trunk/MANIFEST
==============================================================================
--- dbd-oracle/trunk/MANIFEST (original)
+++ dbd-oracle/trunk/MANIFEST Tue Jun 24 08:07:58 2008
@@ -1,8 +1,22 @@
Changes
+dbdimp.c
+dbdimp.h
+dbivport.h
+hints/dgux.pl
+hints/macos_bundle.syms
+hints/macos_lib.syms
+hints/macos_syms.pl
+hints/svr4.pl
+lib/DBD/Oracle/GetInfo.pm
+Makefile.PL
MANIFEST
META.yml Module meta-data (added by MakeMaker)
-Makefile.PL
-Oracle.ex/README
+mk.pm
+mkta.pl
+oci.def OCI.DLL export declarations
+oci8.c
+ocitrace.h
+ora_explain.PL
Oracle.ex/bind.pl
Oracle.ex/commit.pl
Oracle.ex/curref.pl
@@ -11,11 +25,13 @@
Oracle.ex/mktable.pl
Oracle.ex/oradump.pl
Oracle.ex/proc.pl
+Oracle.ex/README
Oracle.ex/sql
Oracle.ex/tabinfo.pl
Oracle.h
Oracle.pm
Oracle.xs
+oraperl.ph Old oraperl file included for completeness of emulation
Oraperl.pm
README
README-files/hpux/Conf-Lincoln-1.06
@@ -32,8 +48,9 @@
README-files/hpux/Conf-Merijn-588-11.23-gcc64
README-files/hpux/Conf-Mike
README-files/hpux/Conf-Roger
-README-files/hpux/Makefile-Lincoln
README-files/hpux/libjava.eml
+README-files/hpux/Makefile-Lincoln
+README.64bit.txt
README.aix.txt
README.clients.txt
README.explain.txt
@@ -48,21 +65,6 @@
README.vms.txt
README.win32.txt
README.wingcc.txt Notes about building with mingw32 and
cygwin32
-Todo
-dbdimp.c
-dbdimp.h
-dbivport.h
-hints/dgux.pl
-hints/macos_bundle.syms
-hints/macos_lib.syms
-hints/macos_syms.pl
-hints/svr4.pl
-lib/DBD/Oracle/GetInfo.pm
-oci.def OCI.DLL export declarations
-oci8.c
-ocitrace.h
-ora_explain.PL
-oraperl.ph Old oraperl file included for completeness of
emulation
t/01base.t
t/10general.t
t/12impdata.t
@@ -93,4 +95,5 @@
t/80ora_charset.t
t/nchar_test_lib.pl
test.pl
+Todo
typemap
Modified: dbd-oracle/trunk/Makefile.PL
==============================================================================
--- dbd-oracle/trunk/Makefile.PL (original)
+++ dbd-oracle/trunk/Makefile.PL Tue Jun 24 08:07:58 2008
@@ -683,7 +683,7 @@
if ($Config{gccversion}) {
$opts{DEFINE} .= ' -Wall -Wcast-align -Wpointer-arith';
$opts{DEFINE} .= ' -Wbad-function-cast -Wcast-qual';
- $opts{DEFINE} .= ' -Wconversion'; # noisy
+ #$opts{DEFINE} .= ' -Wconversion'; # very noisy so remove to see what
people say
$opts{DEFINE} .= ' -Wimplicit -Wimplicit-int
-Wimplicit-function-declaration -Werror-implicit-function-declaration -Wimport
-Winline -Wlong-long -Wmissing-braces -Wmissing-format-attribute
-Wmissing-noreturn -Wmultichar -Wpacked -Wparentheses -Wpointer-arith
-Wreturn-type -Wsequence-point -Wsign-compare -Wswitch -Wtrigraphs -Wundef
-Wuninitialized -Wunreachable-code -Wunused -Wunused-function -Wunused-label
-Wunused-parameter -Wunused-value -Wunused-variable -Wwrite-strings
-Wbad-function-cast -Wmissing-declarations -Wnested-externs'
if $::opt_w;
}
Modified: dbd-oracle/trunk/dbdimp.c
==============================================================================
--- dbd-oracle/trunk/dbdimp.c (original)
+++ dbd-oracle/trunk/dbdimp.c Tue Jun 24 08:07:58 2008
@@ -776,7 +776,7 @@
#if defined(USE_ITHREADS) && defined(PERL_MAGIC_shared_scalar)
if (shared_dbh_ssv && !shared_dbh) {
/* much of this could be replaced with a single sv_setpvn() */
- SvUPGRADE(shared_dbh_priv_sv, SVt_PV) ;
+ (void)SvUPGRADE(shared_dbh_priv_sv, SVt_PV);
SvGROW(shared_dbh_priv_sv, sizeof(imp_dbh_t) + 1) ;
SvCUR (shared_dbh_priv_sv) = sizeof(imp_dbh_t) ;
imp_dbh->refcnt = 1 ;
Modified: dbd-oracle/trunk/oci8.c
==============================================================================
--- dbd-oracle/trunk/oci8.c (original)
+++ dbd-oracle/trunk/oci8.c Tue Jun 24 08:07:58 2008
@@ -1483,8 +1483,8 @@
}
sprintf(s_tz_min,":%02d", tz_minute);
- strcat(str_buf, s_tz_hour);
- strcat(str_buf, s_tz_min);
+ strcat((signed char*)str_buf, s_tz_hour);
+ strcat((signed char*)str_buf, s_tz_min);
str_buf[str_len+7] = '\0';
} else {
@@ -1506,7 +1506,9 @@
case OCI_TYPECODE_BLOB:
case OCI_TYPECODE_BFILE:
raw_sv = newSV(0);
- fetch_lob(sth, fbh->imp_sth,*(OCILobLocator**)attr_value,
typecode, raw_sv, name);
+ fetch_lob(sth, fbh->imp_sth,*(OCILobLocator**)attr_value,
typecode, raw_sv, (signed char*)name);
+
+
av_push(list, raw_sv);
break;
@@ -1667,7 +1669,7 @@
case OCI_TYPECODE_VARRAY :
/* variable array */
fld = &obj->fields[0]; /*get the field */
OCIIterCreate_log_stat(fbh->imp_sth->envhp,
fbh->imp_sth->errhp,
- (CONST OCIColl*) value, &itr,status);
+ (OCIColl*) value, &itr,status);
if (status != OCI_SUCCESS) {
/*not really an error just no
data
@@ -2790,8 +2792,8 @@
if (!fbh->fetch_func) {
/* Copy the truncated value anyway, it may
be of use, */
/* but it'll only be accessible via prior
bind_column() */
- sv_setpvn(sv,
row_data,fb_ary->arlen[imp_sth->rs_array_idx]);
- if ((CSFORM_IMPLIES_UTF8(fbh->csform)) &&
(fbh->ftype != SQLT_BIN)){
+ sv_setpvn(sv, (char
*)row_data,fb_ary->arlen[imp_sth->rs_array_idx]);
+ if ((CSFORM_IMPLIES_UTF8(fbh->csform)) &&
(fbh->ftype != SQLT_BIN)){
SvUTF8_on(sv);
}
}
