Author: byterock
Date: Mon Jan 11 14:44:49 2010
New Revision: 13723
Modified:
dbd-oracle/trunk/Oracle.pm
dbd-oracle/trunk/ocitrace.h
dbd-oracle/trunk/t/31lob_extended.t
Log:
a few quick patches
Modified: dbd-oracle/trunk/Oracle.pm
==============================================================================
--- dbd-oracle/trunk/Oracle.pm (original)
+++ dbd-oracle/trunk/Oracle.pm Mon Jan 11 14:44:49 2010
@@ -1477,12 +1477,14 @@
=item ora_ncs_buff_mtpl
-You can now customize the size of the buffer when selecting a LOBs with the
build in AUTO Lob
-The default value is 1 which should be fine for most situations if you are
converting between
-a NCS on the DB and one on the Client they you might want to set this to 2.
The orginal value
-was 4 which was excessive. For convieance I have added support for a
'ORA_DBD_NCS_BUFFER' enviornemnt
-varaible that you can use at the OS level to set this value. If used it will
take the value at the
-connect stage.
+You can now customize the size of the buffer when selecting LOBs with
+the built in AUTO Lob. The default value is 1 which should be fine
+for most situations. If you are converting between a NCS on the DB and
+one on the Client then you might want to set this to 2. The orignal
+value (prior to version 1.24) of 4 was found to be excessive. For
+convenience I have added support for a 'ORA_DBD_NCS_BUFFER'
+environment variable that you can use at the OS level to set this
+value. If used it will take the value at the connect stage.
See more details in the LOB section of the POD
Modified: dbd-oracle/trunk/ocitrace.h
==============================================================================
--- dbd-oracle/trunk/ocitrace.h (original)
+++ dbd-oracle/trunk/ocitrace.h Mon Jan 11 14:44:49 2010
@@ -267,7 +267,7 @@
stat=OCIAttrSet(th,ht,ah,s1,a,eh); \
(DBD_OCI_TRACEON) ? PerlIO_printf(DBD_OCI_TRACEFP,
\
"%sAttrSet(%p,%s, %p,%lu,Attr=%s,%p)=%s\n",
\
- OciTp,
(void*)th,oci_hdtype_name(ht),sl_t(ah),ul_t(s1),oci_attr_name(a),(void*)eh,
\
+ OciTp, (void*)th,oci_hdtype_name(ht),(void
*)ah,ul_t(s1),oci_attr_name(a),(void*)eh, \
oci_status_name(stat)),stat : stat
#define OCIBindByName_log_stat(sh,bp,eh,p1,pl,v,vs,dt,in,al,rc,mx,cu,md,stat)
\
Modified: dbd-oracle/trunk/t/31lob_extended.t
==============================================================================
--- dbd-oracle/trunk/t/31lob_extended.t (original)
+++ dbd-oracle/trunk/t/31lob_extended.t Mon Jan 11 14:44:49 2010
@@ -1,8 +1,8 @@
#!perl -w
## ----------------------------------------------------------------------------
-## 26exe_array.t
-## By Martin Evans, The Pythian Group
+## 31lob_extended.t
+## By John Scoles, The Pythian Group
## ----------------------------------------------------------------------------
## This run through some bugs that have been found in earlier versions of
DBD::Oracle
## Checks to ensure that these bugs no longer come up
@@ -38,7 +38,7 @@
my ($table, $data0, $data1) = setup_test($dbh);
#
-# bug in DBD::0.21 where if ora_auto_lobs is set and we attempt to
+# bug in DBD::Oracle 1.21 where if ora_auto_lobs is not set and we attempt to
# fetch from a table containing lobs which has more than one row
# we get a segfault. This was due to prefetching more than one row.
#
@@ -50,7 +50,7 @@
eval {$sth1 = $dbh->prepare(
q/begin p_DBD_Oracle_drop_me(?); end;/, {ora_auto_lob => 0});
};
- ok(!$@, "$testname prepare call proc");
+ ok(!$@, "$testname - prepare call proc");
my $sth2;
ok($sth1->bind_param_inout(1, \$sth2, 500, {ora_type => ORA_RSET}),
"$testname - bind out cursor");
@@ -175,13 +175,14 @@
eval {$dbh->do(q/drop procedure p_DBD_Oracle_drop_me/);};
if ($@) {
warn("procedure p_DBD_Oracle_drop_me possibly not dropped" .
- "- check\n") if $dbh->err ne '4043';
+ "- check - $...@\n") if $dbh->err ne '4043';
} else {
diag("procedure p_DBD_Oracle_drop_me dropped");
}
eval {drop_table($dbh);};
if ($@) {
- warn("table $table possibly not dropped - check\n")
+ warn("table $table possibly not dropped - check - $...@\n")
+
if $dbh->err ne '942';
} else {
diag("table $table dropped");
