Author: turnstep
Date: Fri Jul 25 08:42:13 2008
New Revision: 11588

Modified:
   DBD-Pg/trunk/Changes
   DBD-Pg/trunk/t/dbdpg_test_setup.pl

Log:
Don't put global var as destination in for loop - caused $testuser to be 
incorrrectly set
Better message in testing readme.


Modified: DBD-Pg/trunk/Changes
==============================================================================
--- DBD-Pg/trunk/Changes        (original)
+++ DBD-Pg/trunk/Changes        Fri Jul 25 08:42:13 2008
@@ -4,6 +4,7 @@
 
        - Move PQexec structures to statement handle, to prevent 
                excessive malloc and free within execute function. [GSM]
+       - More testing tweaks.
 
 2.8.7 Released July 24, 2008 (subversion r11582)
 

Modified: DBD-Pg/trunk/t/dbdpg_test_setup.pl
==============================================================================
--- DBD-Pg/trunk/t/dbdpg_test_setup.pl  (original)
+++ DBD-Pg/trunk/t/dbdpg_test_setup.pl  Fri Jul 25 08:42:13 2008
@@ -300,7 +300,7 @@
                        if (open $fh, '>', $readme) {
                                print $fh "This is a test directory for DBD::Pg 
and may be removed\n";
                                print $fh "You may want to ensure the 
postmaster has been stopped first.\n";
-                               print $fh "Check the port in the 
postgresql.conf file\n";
+                               print $fh "Check the data/postmaster.pid 
file\n";
                                close $fh or die qq{Could not close "$readme": 
$!\n};
                        }
 
@@ -312,7 +312,8 @@
                        unshift @userlist, $username if defined $username and 
$username ne getpwent;
 
                        my %doneuser;
-                       for $testuser (@userlist) {
+                       for (@userlist) {
+                               $testuser = $_;
                                next if $doneuser{$testuser}++;
                                $uid = (getpwnam $testuser)[2];
                                next if !defined $uid;

Reply via email to