> Thanks for the work on this, everyone. I think I've fixed this, by (as
> properly guessed) making sure that the prepared statement name is nulled
> out when the prepare fails. This makes the next run of execute (if done via
> prepare_cached) re-prepare the statement and this either work or generate
> the correct message. Please give it a test and see if it clears up the
> original problem. Just committed to svn.

Looks good.  All tests (well I skipped critic, author, spell) pass.

I'm on Ubuntu 8.10.

BTW had to use:

    PGINITDB=/usr/lib/postgresql/8.2/bin/initdb  make test

to get the tests to run.  I thought I could use an existing database:

[EMAIL PROTECTED]:~/pg/trunk$ createdb pg_test
CREATE DATABASE

[EMAIL PROTECTED]:~/pg/trunk$ DBI_USER=moseley DBI_DSN='dbi:Pg:dbname=pg_test' 
make test TEST_VERBOSE=1
PGINITDB="" PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" 
"test_harness(1, 'blib/lib', 'blib/arch')" t/*.t
t/00-signature......1..0 # Skip Set the environment variable TEST_SIGNATURE to 
enable this test
skipped
        all skipped: Set the environment variable TEST_SIGNATURE to enable this 
test
t/00basic...........1..3
ok 1 - use DBI;
ok 2 - use DBD::Pg;
ok 3 - Found DBD::Pg::VERSION as "2.11.5"
ok
:t/01connect.........1..0 # Skip Connection to database failed, cannot continue 
testing
# 
# DBI                         Version 1.605
# DBD::Pg                     Version 2.11.5
# Perl                        Version 5.10.0
# OS                          linux
# PostgreSQL (compiled)       ?
# PostgreSQL (target)         ?
# PostgreSQL (reported)       ?
# Default port                ?
# DBI_DSN                     dbi:Pg:dbname=pg_test
# DBI_USER                    moseley
# Test schema                 dbd_pg_testschema
# LANG                        en_US.UTF-8
# Adjusted:                   initdb
# Error was: Previous failure (Failed to run initdb (executable probably not 
available) ENV was:  Final call was: initdb)
skipped

-- 
Bill Moseley
[EMAIL PROTECTED]
Sent from my iMutt

Reply via email to