-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Tim Bunce wrote:
> The doc says "for all strings coming back" which is possibly a little
> ambiguous.
Yes, needs rewording. At the moment, the docs are mostly aimed at
getting you other developers to understand my ideas <grin>.
> (After poking about in the code and libpq docs I'm wondering if
> PQfformat() should be used to confirm that a field is "textual"
> before applying SvUTF8_on.)
Yes, that would be a good choice. If we decide we care about binary
data. At the moment, I can't think of a scenario where simply upgrading
everything will produce wrong output.
> Ideally the docs would have a section on Unicode that discusses it in
> relation to SQL statements, placeholders, attributes (like $sth->{NAME}),
> array stringification and error messages. I.e. at least all the places
> that have SvUTF8/_on/_off() calls, plus anywhere that character data
> gets passed into libpq.
Oh yeah, this will be a major release with lots of detailed docs
and prominent warnings. :)
> I would urge you to implement good test coverage for unicode support.
Yes, definitely. Thanks for those links. I will tackle them if I
get some tuits, but it would be nice if others pitched in.
Probably worthy of its own test file. Thanks for the feedback.
- --
Greg Sabino Mullane g...@turnstep.com
End Point Corporation http://www.endpoint.com/
PGP Key: 0x14964AC8 201307032217
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----
iEYEAREDAAYFAlHU2zoACgkQvJuQZxSWSshYzQCaA7Pr8MHGk3HHKyPdtRZBgei7
gwkAoLClO0mxOEMXR68HfnEhBjq+ke7S
=e/ov
-----END PGP SIGNATURE-----
