On Thu, May 07, 2009 at 11:17:27AM +1000, Toby Corkindale wrote: > Tim Bunce wrote: >> On Wed, May 06, 2009 at 05:01:56PM +0900, Kenichi Ishigaki wrote: >>> Hi Toby, >>> >>> applied your patch with slight modification (changed function >>> names in dbdimp.c/h and, added a test for pre-1.608 DBI, etc). >>> As for the modification of your DBI, DBI 1.608 with sqlite_ >>> prefix is out on the 5th, May (Tim++). So upgrade your DBI >>> and everything will be fine. >> >> But not for people who can't upgrade their DBI, for whatever reason. >> There should be an "if ($DBI::VERSION >= 1.608)" around the >> install_method() calls and a note in the docs. >> >> Either that, or make DBI 1.608 a pre-requisite - but that would be a bit >> extreem. > > Right.. > Can the methods can still be called via func($filename, > 'sqlite_backup_to_file') even on DBI 1.607? > (I think so?)
Yes. Though RaiseError etc. don't apply to calls via func(). > Or can DBD::SQLite register itself in DBI's registered-classes hash somehow? No. Tim. > -Toby > >>> On Wed, 06 May 2009 16:09:42 +1000, Toby Corkindale >>> <[email protected]> wrote: >>> >>>> Please find attached my revised patch for adding online backup support >>>> to DBD::SQLite. >>>> >>>> This time it includes a unit test, and uses the sqlite_ prefix for >>>> functions, and uses the install_method() system from DBI to provide >>>> those functions. >>>> >>>> I note that I needed to patch my local DBI.pm to include: >>>> >>>> sqlite_ => { class => 'DBD::SQLite' } >>>> >>>> So I'm not sure what effect that will have on backward compatibility >>>> with current stable versions of DBI? >>>> >>>> -Toby _______________________________________________ DBD-SQLite mailing list [email protected] http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbd-sqlite
