Author: timbo
Date: Tue Feb 24 01:43:49 2004
New Revision: 138
Modified:
dbi/trunk/Changes
dbi/trunk/DBI.pm
dbi/trunk/DBI.xs
dbi/trunk/ToDo
Log:
Corrected typos in docs thanks to Steffen Goeldner.
Other minor changes
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Tue Feb 24 01:43:49 2004
@@ -12,6 +12,7 @@
Changed attributes (NAME, TYPE etc) of non-executed statement
handle to be undef instead of triggering an error.
+ Corrected typos in docs thanks to Steffen Goeldner.
=head1 CHANGES in DBI 1.41 (svn rev 130), 22nd February 2004
@@ -39,7 +40,6 @@
Added way for drivers to indicate 'success with info' or 'warning'
by setting err to "0" for warning and "" for information.
Both values are false and so don't trigger RaiseError etc.
- Warnings (err="0") are automatically printed if PrintError is set.
Thanks to Steffen Goeldner for the original idea.
Added $h->{HandleSetErr} = sub { ... } to be called at the
point that an error, warn, or info state is recorded.
Modified: dbi/trunk/DBI.pm
==============================================================================
--- dbi/trunk/DBI.pm (original)
+++ dbi/trunk/DBI.pm Tue Feb 24 01:43:49 2004
@@ -2718,7 +2718,7 @@
The handle C<err> value is set to $err if: $err is true; or handle
C<err> value is undef; or $err is defined and the length is greater
than the handle C<err> length. The effect is that an 'information'
-state only overides undef; a 'warning' overrides undef or 'information',
+state only overrides undef; a 'warning' overrides undef or 'information',
and an 'error' state overrides anything.
The handle C<state> value is set to $state if $state is true and
@@ -2827,7 +2827,7 @@
=item C<Warn> (boolean, inherited)
The C<Warn> attribute enables useful warnings for certain bad
-practices. It is enabled by default and should only be disable is
+practices. It is enabled by default and should only be disabled in
rare circumstances. Since warnings are generated using the Perl
C<warn> function, they can be intercepted using the Perl C<$SIG{__WARN__}>
hook.
@@ -2857,7 +2857,7 @@
The C<Executed> attribute for a database handle is cleared by the
commit() and rollback() methods. The C<Executed> attribute of a
statement handle is not cleared by the DBI under any circumstances
-and so acts as a permenant record of whether the statement handle
+and so acts as a permanent record of whether the statement handle
was ever used.
The C<Executed> attribute was added in DBI 1.41.
@@ -3070,7 +3070,7 @@
The C<HandleSetErr> and C<HandleError> subroutines differ in subtle
but significant ways. HandleError is only invoked at the point where
the DBI is about to return to the application with C<err> set true.
-It's not invoked by the failure of a method that's been caled by
+It's not invoked by the failure of a method that's been called by
another DBI method. HandleSetErr, on the other hand, is called
whenever set_err() is called with a defined C<err> value, even if false.
So it's not just for errors, despite the name, but also warn and info states.
@@ -3179,7 +3179,7 @@
SELECT long_column_name, ... FROM table WHERE ...
});
-You may need to take etra care if the table can be modified between
+You may need to take extra care if the table can be modified between
the first select and the second being executed.
See L</LongTruncOk> for more information on truncation behaviour.
@@ -5330,7 +5330,7 @@
to specify that you'd like the column (which presumably is some
kind of datetime type) to be returned in the standard format for
SQL_DATETIME, which is 'YYYY-MM-DD HH:MM:SS', rather than the
-native formatting the database would normaly use.
+native formatting the database would normally use.
There's no $var_to_bind in that example to emphasize the point
that bind_col() works on the underlying column value and not just
Modified: dbi/trunk/DBI.xs
==============================================================================
--- dbi/trunk/DBI.xs (original)
+++ dbi/trunk/DBI.xs Tue Feb 24 01:43:49 2004
@@ -1164,8 +1164,7 @@
if (DBIc_TYPE(imp_xxh) == DBIt_ST) {
imp_sth_t *imp_sth = (imp_sth_t*)imp_xxh;
- if (DBIc_FIELDS_AV(imp_sth));
- sv_free((SV*)DBIc_FIELDS_AV(imp_sth));
+ sv_free((SV*)DBIc_FIELDS_AV(imp_sth));
}
sv_free(DBIc_IMP_DATA(imp_xxh)); /* do this first */
Modified: dbi/trunk/ToDo
==============================================================================
--- dbi/trunk/ToDo (original)
+++ dbi/trunk/ToDo Tue Feb 24 01:43:49 2004
@@ -33,14 +33,14 @@
that are not able to determine that themselves.
The DBI won't support automatic character set conversions.
-Change "TraceLevel" to support "topic bits" that can be set
-independantly of the current integer "level". In other words
-the lowest 4 bits will be used for the "level", as now.
+Assign "topic bits" to TraceLevel.
+Lowest 4 bits will be used for the "level", as now.
The next 4 bits are reserved. The next 16bits are each
associated with a particular topic defined by the DBI.
The top 8 bits are from for the driver to use.
-The topics will be assigned letters which can be used to
-set the trace level to make it easier to remember settings.
+
+%DBI::TraceTopics & %DBD::Foo::TraceTopics
+
Need to decide which drivers should use, DBIS->debug or imp_xxh->debug.
Change macro to get debug level to only return last 4 bits.
Add macro framework for 'topic' bits.
