Author: timbo
Date: Tue Mar 9 06:03:23 2004
New Revision: 204
Modified:
dbi/trunk/Changes
dbi/trunk/ToDo
dbi/trunk/lib/DBI/DBD.pm
Log:
Clarify when a fetch method should turn off the Active attribute.
Tweak changes and todo
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Tue Mar 9 06:03:23 2004
@@ -29,7 +29,7 @@
setting the trace level to a non-numeric value:
$h->{TraceLevel}="foo|SQL|7"; $h->trace("foo|SQL|7");
DBI->connect("dbi:Driver(TraceLevel=SQL|foo):...", ...);
- Added to and reworked the trace documentation.
+ Added to, and reworked, the trace documentation.
Major driver additions that Jeff Zucker and I have been working on:
Modified: dbi/trunk/ToDo
==============================================================================
--- dbi/trunk/ToDo (original)
+++ dbi/trunk/ToDo Tue Mar 9 06:03:23 2004
@@ -33,15 +33,10 @@
that are not able to determine that themselves.
The DBI won't support automatic character set conversions.
-Assign "topic bits" to TraceLevel.
-Lowest 4 bits will be used for the "level", as now.
-The next 4 bits are reserved. The next 16bits are each
-associated with a particular topic defined by the DBI.
-The top 8 bits are from for the driver to use.
-
+Define "topic bits" for TraceLevel.
%DBI::TraceTopics & %DBD::Foo::TraceTopics
-
-Need to decide which drivers should use, DBIS->debug or imp_xxh->debug.
+"Lint" topic for extra checking, eg warn on $sth DESTROY if still Active
+"Verbose" topic adds verbosity to any other enabled topics
Change macro to get debug level to only return last 4 bits.
Add macro framework for 'topic' bits.
Use one bit for logging just the SQL statement executed
@@ -83,6 +78,7 @@
Add PERL_NO_GET_CONTEXT for multiplicity/threads?
force it for drivers?
And enable xsbypass in dispatch if possible.
+Remove PERL_POLLUTE
Add function pointer for setting fetched field values into DBIS.
Drivers would use this instead of calling sv_setpv (etc) themselves.
Modified: dbi/trunk/lib/DBI/DBD.pm
==============================================================================
--- dbi/trunk/lib/DBI/DBD.pm (original)
+++ dbi/trunk/lib/DBI/DBD.pm Tue Mar 9 06:03:23 2004
@@ -1419,6 +1419,10 @@
Note the use of the method I<_set_fbav>: This is required so that
I<bind_col> and I<bind_columns> work.
+If an error occurs which leaves the $sth in a state where remaining rows
+can't be fetched then Active should be turned off
+before the method returns.
+
=cut
#=head4 Statement attributes
@@ -2772,6 +2776,10 @@
=back
+If an error occurs which leaves the $sth in a state where remaining
+rows can't be fetched then Active should be turned off before the
+method returns.
+
=cut
#=head3 The dbd_st_finish3 method
