Author: timbo
Date: Fri Apr 30 04:05:52 2004
New Revision: 310
Modified:
dbi/trunk/Changes
dbi/trunk/DBI.pm
dbi/trunk/ToDo
dbi/trunk/lib/DBI/DBD.pm
Log:
Fixed connect() and connect_cached() RaiseError/PrintError
which would sometimes show "(no error string)" as the error.
Added warning if build directory path contains whitespace.
Removed "may change" warnings from the docs for table_info(),
primary_key_info(), and foreign_key_info() methods.
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Fri Apr 30 04:05:52 2004
@@ -8,11 +8,16 @@
=head1 CHANGES in DBI 1.43 (svn rev XXX), XXth XXX 2004
+Extended bind_col() TYPE attribute specification to imply
+standard formating of value, eg SQL_DATE implies 'YYYY-MM-DD'.
+
+ Fixed connect() and connect_cached() RaiseError/PrintError
+ which would sometimes show "(no error string)" as the error.
Fixed compiler warning thanks to Paul Marquess.
Fixed "trace level set to" trace message thanks to H.Merijn Brand.
Fixed DBD::DBM $dbh->{dbm_tables}->{...} to be keyed by the
table name not the file name thanks to Jeff Zucker.
- Fixed last_insert_id(...) thanks to Rudy Lippan.
+ Fixed last_insert_id(...) usage check thanks to Rudy Lippan.
Fixed propagation of scalar/list context into proxied methods.
Fixed DBI::Profile::DESTROY to not alter [EMAIL PROTECTED]
Fixed DBI::ProfileDumper new() docs thanks to Michael Schwern.
@@ -21,6 +26,10 @@
$attr->{MaxRows} is defined.
Changed more tests to use Test::More thanks to Andy Lester.
+ Added warning if build directory path contains whitespace.
+ Removed "may change" warnings from the docs for table_info(),
+ primary_key_info(), and foreign_key_info() methods.
+
=head1 CHANGES in DBI 1.42 (svn rev 222), 12th March 2004
Fixed $sth->{NUM_OF_FIELDS} of non-executed statement handle
Modified: dbi/trunk/DBI.pm
==============================================================================
--- dbi/trunk/DBI.pm (original)
+++ dbi/trunk/DBI.pm Fri Apr 30 04:05:52 2004
@@ -587,7 +587,10 @@
unless ($dbh = $drh->$connect_meth($dsn, $user, $pass, $attr)) {
$user = '' if !defined $user;
$dsn = '' if !defined $dsn;
- my $errstr = $drh->errstr;
+ # $drh->errstr isn't safe here because $dbh->DESTROY may not have
+ # been called yet and so the dbh errstr would not have been copied
+ # up to the drh errstr. Certainly true for connect_cached!
+ my $errstr = $DBI::errstr;
$errstr = '(no error string)' if !defined $errstr;
my $msg = "$class connect('$dsn','$user',...) failed: $errstr";
DBI->trace_msg(" $msg\n");
@@ -3836,8 +3839,6 @@
=item C<table_info>
-B<Warning:> This method is experimental and may change.
-
$sth = $dbh->table_info( $catalog, $schema, $table, $type );
$sth = $dbh->table_info( $catalog, $schema, $table, $type, \%attr );
@@ -4027,8 +4028,6 @@
=item C<primary_key_info>
-B<Warning:> This method is experimental and may change.
-
$sth = $dbh->primary_key_info( $catalog, $schema, $table );
Returns an active statement handle that can be used to fetch information
@@ -4081,8 +4080,6 @@
=item C<foreign_key_info>
-B<Warning:> This method is experimental and may change.
-
$sth = $dbh->foreign_key_info( $pk_catalog, $pk_schema, $pk_table
, $fk_catalog, $fk_schema, $fk_table );
Modified: dbi/trunk/ToDo
==============================================================================
--- dbi/trunk/ToDo (original)
+++ dbi/trunk/ToDo Fri Apr 30 04:05:52 2004
@@ -146,6 +146,8 @@
--- Other changes
+See comment under $drh->$connect_meth in DBI.pm about $drh->errstr
+
Ensure child $h has err reset after connect_cached() or prepare_cached()
or else document that $DBI:err may be true after those methods even
though they haven't failed. Umm.
Modified: dbi/trunk/lib/DBI/DBD.pm
==============================================================================
--- dbi/trunk/lib/DBI/DBD.pm (original)
+++ dbi/trunk/lib/DBI/DBD.pm Fri Apr 30 04:05:52 2004
@@ -3644,6 +3644,11 @@
"in the current directory path ($cwd) may cause problems\a\n\n";
sleep 2;
}
+ if ($cwd =~ /\s/) {
+ warn "*** Warning: whitespace characters ",
+ "in the current directory path ($cwd) may cause problems\a\n\n";
+ sleep 2;
+ }
if ( $^O eq 'MSWin32'
&& $Config{cc} eq 'cl'
&& !(exists $ENV{'LIB'} && exists $ENV{'INCLUDE'}))
