[svn:dbi] rev 370 - in dbi/trunk: . lib/DBD

[timbo]

Author: timbo
Date: Mon Jun 28 12:41:04 2004
New Revision: 370

Modified:
   dbi/trunk/Changes
   dbi/trunk/ToDo
   dbi/trunk/lib/DBD/Sponge.pm
Log:
Fixed DBD::Sponge not to generate warning with threads.
Tweaks to ToDo


Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes   (original)
+++ dbi/trunk/Changes   Mon Jun 28 12:41:04 2004
@@ -22,6 +22,7 @@
   Fixed _load_class to propagate $@ thanks to Drew Taylor.
   Fixed compile warnings on Win32 thanks to Robert Baron.
   Fixed problem building with recent versions of MakeMaker.
+  Fixed DBD::Sponge not to generate warning with threads.
 
   Changed selectall_arrayref() to call finish() if
     $attr->{MaxRows} is defined.

Modified: dbi/trunk/ToDo
==============================================================================
--- dbi/trunk/ToDo      (original)
+++ dbi/trunk/ToDo      Mon Jun 28 12:41:04 2004
@@ -54,7 +54,7 @@
 Add discard_pending_rows() as an alias
 for finish() - which will be deprecated.
 
-$sth->{ParamTypes} eg { "1" => SQL_VARCHAR, "2" => { TYPE=>SQL_VARCHAR, ora_type=>99 
}};
+$sth->{ParamAttr} eg { "1" => SQL_VARCHAR, "2" => { TYPE=>SQL_VARCHAR, ora_type=>99 
}};
 
 $h->{KidsHandles} = ref to cache (array or hash?)
 of weakrefs to child handles.
@@ -424,7 +424,9 @@
 
 Add mechanism so "call path" can be included in the Path of the
 profile data. Something like "<basename>@<linenum>;..." or
-optionally just the basename part.
+optionally just the basename part. (See log_where())
+
+Allow code ref in Path and use result as string for that element of the Path.
 
 Fix dbi_time for Windows by using or linking-to Time::HiRes code.
 

Modified: dbi/trunk/lib/DBD/Sponge.pm
==============================================================================
--- dbi/trunk/lib/DBD/Sponge.pm (original)
+++ dbi/trunk/lib/DBD/Sponge.pm Mon Jun 28 12:41:04 2004
@@ -16,11 +16,13 @@
 
     $drh = undef;      # holds driver handle once initialised
     $err = 0;          # The $DBI::err value
+    my $methods_already_installed;
 
     sub driver{
        return $drh if $drh;
 
-       DBD::Sponge::db->install_method("sponge_test_installed_method");
+       DBD::Sponge::db->install_method("sponge_test_installed_method")
+               unless $methods_already_installed++;
 
        my($class, $attr) = @_;
        $class .= "::dr";