Author: timbo
Date: Thu Aug 26 07:11:22 2004
New Revision: 442
Modified:
dbi/trunk/Changes
dbi/trunk/dbivport.h
dbi/trunk/lib/DBD/File.pm
dbi/trunk/lib/DBI/DBD.pm
dbi/trunk/lib/DBI/PurePerl.pm
Log:
Fixed DBD::File finish() method to return 1 thanks to Jan Dubois.
Fixed dbivport.h warnings on some compilers.
Fixed DBI::PurePerl warning from beta release versions of Math::BigInt
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Thu Aug 26 07:11:22 2004
@@ -6,7 +6,10 @@
=head2 Changes in DBI 1.44 (svn rev ???), XXX
+fix utf8 leakage
+
Fixed build issues on VMS thanks to Jakob Snoer.
+ Fixed DBD::File finish() method to return 1 thanks to Jan Dubois.
Changed bind_param_array() so it doesn't require all bind arrays
to have the same number of elements.
Modified: dbi/trunk/dbivport.h
==============================================================================
--- dbi/trunk/dbivport.h (original)
+++ dbi/trunk/dbivport.h Thu Aug 26 07:11:22 2004
@@ -18,7 +18,7 @@
*/
#define DBIh_SET_ERR_CHAR(h, imp_xxh, err_c, err_i, errstr, state, method) \
sv_setiv(DBIc_ERR(imp_xxh), err_i); \
- (state) ? sv_setpv(DBIc_STATE(imp_xxh), state) :
SvOK_off(DBIc_STATE(imp_xxh)); \
+ (state) ? (void)sv_setpv(DBIc_STATE(imp_xxh), state) :
(void)SvOK_off(DBIc_STATE(imp_xxh)); \
sv_setpv(DBIc_ERRSTR(imp_xxh), errstr)
#endif
Modified: dbi/trunk/lib/DBD/File.pm
==============================================================================
--- dbi/trunk/lib/DBD/File.pm (original)
+++ dbi/trunk/lib/DBD/File.pm Thu Aug 26 07:11:22 2004
@@ -441,6 +441,7 @@
my $sth = shift;
$sth->{Active}=0;
delete $sth->{f_stmt}->{data};
+ return 1;
}
sub fetch ($) {
my $sth = shift;
Modified: dbi/trunk/lib/DBI/DBD.pm
==============================================================================
--- dbi/trunk/lib/DBI/DBD.pm (original)
+++ dbi/trunk/lib/DBI/DBD.pm Thu Aug 26 07:11:22 2004
@@ -3684,14 +3684,14 @@
# so 'make' creates them and 'make clean' deletes them
my %test_variants = (
pp => { name => "DBI::PurePerl",
- add => [ '$ENV{DBI_PUREPERL}=2;' ],
+ add => [ 'local $ENV{DBI_PUREPERL} = 2;' ],
},
mx => { name => "DBD::Multiplex",
- add => [ q{$ENV{DBI_AUTOPROXY}='dbi:Multiplex:';} ],
+ add => [ q{local $ENV{DBI_AUTOPROXY} = 'dbi:Multiplex:';} ],
}
# px => { name => "DBD::Proxy",
# need mechanism for starting/stopping the proxy server
- # add => [ q{$ENV{DBI_AUTOPROXY}='dbi:Proxy:XXX';} ],
+ # add => [ q{local $ENV{DBI_AUTOPROXY} = 'dbi:Proxy:XXX';} ],
# }
);
# currently many tests fail - DBD::Multiplex needs more work
Modified: dbi/trunk/lib/DBI/PurePerl.pm
==============================================================================
--- dbi/trunk/lib/DBI/PurePerl.pm (original)
+++ dbi/trunk/lib/DBI/PurePerl.pm Thu Aug 26 07:11:22 2004
@@ -521,7 +521,7 @@
elsif ($type == 1) { # Fowler/Noll/Vo hash
# see http://www.isthe.com/chongo/tech/comp/fnv/
require Math::BigInt; # feel free to reimplement w/o BigInt!
- my $version = $Math::BigInt::VERSION || 0;
+ (my $version = $Math::BigInt::VERSION || 0) =~ s/_.*//; # eg "1.70_01"
if ($version >= 1.56) {
$hash = Math::BigInt->new(0x811c9dc5);
for my $uchar (unpack ("C*", $key)) {
