Author: timbo
Date: Tue Jun 21 13:17:38 2005
New Revision: 1084
Modified:
dbi/trunk/Changes
dbi/trunk/lib/DBD/ExampleP.pm
dbi/trunk/lib/DBD/Proxy.pm
dbi/trunk/t/80proxy.t
Log:
Fixed ping in DBD::Proxy thanks to George Campbell
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Tue Jun 21 13:17:38 2005
@@ -11,6 +11,7 @@ DBI::Changes - List of significant chang
Fixed handling of take_imp_data() and dbi_imp_data attribute.
Fixed bugs in DBD::DBM thanks to Jeff Zucker.
Fixed bug in DBI::ProfileDumper thanks to Sam Tregar.
+ Fixed ping in DBD::Proxy thanks to George Campbell.
Changed internals to be more strictly coded thanks to Andy Lester.
Changed warning about multiple copies of Driver.xst found in @INC
Modified: dbi/trunk/lib/DBD/ExampleP.pm
==============================================================================
--- dbi/trunk/lib/DBD/ExampleP.pm (original)
+++ dbi/trunk/lib/DBD/ExampleP.pm Tue Jun 21 13:17:38 2005
@@ -199,6 +199,11 @@
}
+ sub ping {
+ return 2; # used by t/80proxy.t
+ }
+
+
sub disconnect {
shift->STORE(Active => 0);
return 1;
Modified: dbi/trunk/lib/DBD/Proxy.pm
==============================================================================
--- dbi/trunk/lib/DBD/Proxy.pm (original)
+++ dbi/trunk/lib/DBD/Proxy.pm Tue Jun 21 13:17:38 2005
@@ -221,6 +221,7 @@ $DBD::Proxy::db::imp_data_size = 0;
sub commit;
sub rollback;
+sub ping;
use vars qw(%ATTR $AUTOLOAD);
Modified: dbi/trunk/t/80proxy.t
==============================================================================
--- dbi/trunk/t/80proxy.t (original)
+++ dbi/trunk/t/80proxy.t Tue Jun 21 13:17:38 2005
@@ -71,7 +71,7 @@ unlink $config_file;
or die "Failed to create config file $config_file: $!";
my($handle, $port);
-my $numTests = 124;
+my $numTests = 125;
if (@ARGV) {
$port = $ARGV[0];
} else {
@@ -132,7 +132,9 @@ eval {
Test($@ eq "BANG!!!\n", "\$@ value lost");
print "Doing a ping.\n";
-Test($dbh->ping);
+$_ = $dbh->ping;
+Test($_);
+Test($_ eq '2'); # ping was DBD::ExampleP's ping
print "Ensure CompatMode enabled.\n";
Test($dbh->{CompatMode});