Author: timbo
Date: Wed Jan 11 05:59:36 2006
New Revision: 2390
Modified:
dbi/trunk/Changes
dbi/trunk/DBI.xs
dbi/trunk/Makefile.PL
Log:
Changed Makefile.PL to avoid incompatible options for old gcc.
Modified: dbi/trunk/Changes
==============================================================================
--- dbi/trunk/Changes (original)
+++ dbi/trunk/Changes Wed Jan 11 05:59:36 2006
@@ -13,6 +13,7 @@ DBI::Changes - List of significant chang
Changed DBI::ProfileData to be more forgiving of systems with
unstable clocks (where time may go backwards occasionally).
Clarified the 'Subclassing the DBI' docs.
+ Changed Makefile.PL to avoid incompatible options for old gcc.
Added 'fetch array of hash refs' example to selectall_arrayref
docs thanks to Tom Schindl.
Modified: dbi/trunk/DBI.xs
==============================================================================
--- dbi/trunk/DBI.xs (original)
+++ dbi/trunk/DBI.xs Wed Jan 11 05:59:36 2006
@@ -3668,7 +3668,6 @@ _install_method(dbi_class, meth_name, fi
SV **svp;
dbi_ima_t *ima = NULL;
(void)dbi_class;
- (void)cv; /* avoid 'unused variable' warning */
if (strnNE(meth_name, "DBI::", 5)) /* XXX m/^DBI::\w+::\w+$/ */
croak("install_method %s: invalid class", meth_name);
Modified: dbi/trunk/Makefile.PL
==============================================================================
--- dbi/trunk/Makefile.PL (original)
+++ dbi/trunk/Makefile.PL Wed Jan 11 05:59:36 2006
@@ -142,13 +142,14 @@ $opts{CAPI} = 'TRUE' if $Config{archname
if (my $gccversion = $Config{gccversion}) { # ask gcc to be more pedantic
warn "WARNING: Your GNU C $gccversion compiler is very old. Please upgrade
it and rebuild perl.\n"
if $gccversion =~ m/^\D*(1|2\.[1-8])/;
+ print "Your perl was compiled with gcc (version $Config{gccversion}),
okay.\n";
$gccversion =~ s/[^\d\.]//g; # just a number please
$opts{DEFINE} .= ' -W -Wall -Wpointer-arith -Wbad-function-cast';
$opts{DEFINE} .= ' -Wno-comment -Wno-sign-compare -Wno-cast-qual';
- $opts{DEFINE} .= ' -Wdisabled-optimization -Wmissing-noreturn
-Wno-unused-parameter'
- if $gccversion ge "3.0";
+ $opts{DEFINE} .= ' -Wmissing-noreturn -Wno-unused-parameter' if
$gccversion ge "3.0";
if ($is_developer && $::opt_g) {
$opts{DEFINE} .= ' -DPERL_GCC_PEDANTIC -ansi -pedantic' if $gccversion
ge "3.0";
+ $opts{DEFINE} .= ' -Wdisabled-optimization' if $gccversion
ge "3.0";
$opts{DEFINE} .= ' -Wmissing-prototypes';
}
}
